Add initial Fuse implementation for Stream #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacejam
commented
Aug 16, 2019
matklad
reviewed
Aug 16, 2019
matklad
approved these changes
Aug 16, 2019
There was a problem hiding this comment.
LGTM!
Really, I think it's a very nasty usability problem that futures::select! requires a FusedStream (as opposed to calling .fuse internally, like it is recommended to do for iterators), but I think I see why this needs to be the case.
I wonder if we have long-term plan here... Could we just require that all streams are fused?
yoshuawuyts
reviewed
Aug 16, 2019
added 3 commits
September 17, 2019 23:48
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
yoshuawuyts
force-pushed
the
tyler_fuse
branch
from
4c45443 to
aa94d45
Compare
Signed-off-by: Yoshua Wuyts <yoshuawuyts@gmail.com>
|
I've rebased @spacejam's excellent work on master; it's all passing now. Also removed the two helper methods on the Given the amount of review this has had, I think this should be good to merge. Ref #129. bors r+ |
Build succeeded
|
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matklad does this address your use case?