Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new channels #827

Closed
wants to merge 2 commits into from
Closed

feat: new channels #827

wants to merge 2 commits into from

Conversation

dignifiedquire
Copy link
Member

@dignifiedquire dignifiedquire commented Jun 27, 2020

  • add new top level channel module
  • reimplement existing channels using async-channel

- add new top level `channels` module
- reimplement existing channels using `async-channel`
@ghost
Copy link

ghost commented Jun 27, 2020

Looks like channel module is in the wrong place: it's in async_std::channel, while it should be async_std::sync::channel

@yoshuawuyts
Copy link
Contributor

Looks like channel module is in the wrong place: it's in async_std::channel

@stjepang that's the intent; the libs team has been talking about possibly breaking std::sync up into smaller bits anyway, and we figured a channel impl would be a good candidate for this. But now that you know it's intentional I'm curious to hear what you think!

@ghost
Copy link

ghost commented Jun 29, 2020

Ha, interesting! I actually like channel as a top-level module and wish std did the same.

@dignifiedquire
Copy link
Member Author

Going to close this for now. Will rework later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants