Skip to content

Book: Accept Loop Variable Fixes #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2020
Merged

Book: Accept Loop Variable Fixes #846

merged 2 commits into from
Aug 3, 2020

Conversation

ryanbrainard
Copy link
Contributor

In the example accept loop in the book, there are a couple of minor variable errors:

  1. Should be matching on result instead of stream.
  2. The call to eprintln! has a {} placeholder, but e needs to be passed in.

@ryanbrainard
Copy link
Contributor Author

CI is failing in the same way as described here: #845 (comment). This should pass once the root cause of that is fixed.

yoshuawuyts
yoshuawuyts approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

@yoshuawuyts yoshuawuyts merged commit 19dcced into async-rs:master Aug 3, 2020
@ryanbrainard ryanbrainard deleted the book-fix-accept-loop branch August 3, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanbrainard @yoshuawuyts