Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename files from heap to bin_heap #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Ben-PH
Copy link

@Ben-PH Ben-PH commented Mar 15, 2020

The use of 'heap' for labelling the data structure clashes with dynamic
memory 'heap'. This is purely a naming convention change, and should have
no affect on implementation.

The use of 'heap' for labelling the data structure clashes with dynamic
memory 'heap'. This is purely a naming convention change, and should have
no affect on implementation.
@Ben-PH
Copy link
Author

Ben-PH commented Mar 15, 2020

This is an opinionated PR, with the benefit being purely subjective. rustfmt CI failure is inconsequential to this PR. Edit: fixed it.

My arguments in favor of accepting this PR:

  • reduces risk of miscommunication
  • Will more easily filter out code-base searches on the topic of dynamic memory
  • Searches in the code base for the heap data structure should become easier
  • It is a low-risk act that positively reinforces the behavior of voluntary participating constructively in open source.

Arguments against:

  • It's submission is consistent with bike-shedding behavior
  • Put together based on personal opinion that wasn't discussed
  • Did not look into reasoning for original choice, so hidden gremlins would stay hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant