ci: implemment pagination #266

Gmin2 · 2023-12-17T09:24:54Z

Description
Each co-author appear in a new line and implement pagination
Related issue(s)
Resolves #263

github-actions

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

KhudaDad414

TBH I am not a fan of writing this action in bash. it is hard to maintain ( I don't speak bash). 😆
can you rewrite in in almighty js?

Gmin2 · 2023-12-18T15:34:38Z

TBH I am not a fan of writing this action in bash. it is hard to maintain ( I don't speak bash). 😆 can you rewrite in in almighty js?

i am too not a big fan of bash but as @smoya had mentioned in the issue to use some bash thats why i have used bash but no problem i am converting it too js
cc @KhudaDad414

smoya · 2023-12-18T16:16:51Z

TBH I am not a fan of writing this action in bash. it is hard to maintain ( I don't speak bash). 😆 can you rewrite in in almighty js?

i am too not a big fan of bash but as @smoya had mentioned in the issue to use some bash thats why i have used bash but no problem i am converting it too js
cc @KhudaDad414

Totally no strong opinion on using bash or any language of our preference TBH. So 👍 on my side.

Gmin2 · 2023-12-18T16:30:07Z

@KhudaDad414 @smoya should i rewrite this in js or not

derberg · 2023-12-18T17:58:49Z

@Min2who please rewrite to JS as we have a lot of experience with it and it will be much better to maintain long term.

please use https://github.com/actions/github-script action that already have pagination related plugins added so writing such script will be much better DX and also much readable ❤️

so one step will be just getting data from GitHub API (by default afaik response will be stored as part of output that you will be able to access from another step https://github.com/actions/github-script?tab=readme-ov-file#reading-step-results). And in another step you will construct a commit message.

such approach will make maintenance much better + will make is easier to debug in future

smoya · 2023-12-19T01:13:10Z

i am too not a big fan of bash

As @derberg stated, +1 to use JS. From the very moment this is not gonna be a simple one liner as it was, it will become very hard to maintain.

Gmin2 · 2023-12-21T18:02:46Z

@KhudaDad414 @derberg @smoya can you suggest me some way to test this actions locally

KhudaDad414 · 2023-12-22T13:36:23Z

@Min2who actions are a little hard to test especially this one. I would suggest testing the script you write separately and making sure it gets what you want. testing the entire workflow is a little more challenging, you may need to test it on your fork. I think testing the script here suffices.

Gmin2 · 2024-01-14T10:47:43Z

i have updated this action using the github octokit.paginate plugin and have test this in my local fork action in this

cc @smoya @KhudaDad414

.github/workflows/automerge-for-humans-merging.yml

Gmin2 · 2024-01-15T17:02:23Z

made the changes

cc @KhudaDad414

KhudaDad414

LGTM! please wait for @derberg's review. 🙇

Gmin2 · 2024-01-21T13:19:10Z

LGTM! please wait for @derberg's review. 🙇

waiting 🙇‍♂️
cc @derberg

derberg

@Min2who hey, left some comments how you can improve the action

can you share some example where did you test it, a test run?

.github/workflows/automerge-for-humans-merging.yml

Gmin2 · 2024-02-28T14:21:12Z

@Min2who hey, left some comments how you can improve the action

can you share some example where did you test it, a test run?

This is my test run @derberg

derberg · 2024-03-11T16:55:32Z

@utnim2 did you see my other comments?

Gmin2 · 2024-03-11T16:57:02Z

@utnim2 did you see my other comments?

ahh sorry , working on it

Gmin2 · 2024-03-11T21:26:18Z

Done the reviewed changes

The test of this action here

cc @derberg @KhudaDad414

.github/workflows/automerge-for-humans-merging.yml

derberg · 2024-04-18T10:28:14Z

@utnim2 lgtm but there were some changes done since initial implementation, can you show your changes somewhere in action, in some test repo? I can help if you need someone to open a PR in your repo, and then you make edits to make sure it works

tatality-lgtm · 2024-04-18T21:16:05Z

.github/workflows/automerge-for-humans-merging.yml

-          # 5. Removes repeated authors (authors can have more than one commit in the PR).
-          # 6. Builds the `Co-authored-by: ...` lines with actual info.
-          # 7. Transforms the array into plain text. Thanks to this, the actual stdout of this step can be used by the next Workflow step (wich is basically the automerge).
-          cmd: | 


alechkos

Hi @Gmin2, I added some comments that will fix issues on workflow run.

alechkos · 2024-07-07T15:42:36Z

.github/workflows/automerge-for-humans-merging.yml

+                const commitsResponse = await github.paginate("GET /repos/{owner}/{repo}/pulls/{pull_number}/commits", {
+                  owner: repository.split('/')[0],
+                  repo: repository.split('/')[1],
+                  pull_number: ${{ github.event.number }},
+                  per_page: 100,
+                });


Simplification and correction of the way to access the repo information:

Suggested change

const commitsResponse = await github.paginate("GET /repos/{owner}/{repo}/pulls/{pull_number}/commits", {

owner: repository.split('/')[0],

repo: repository.split('/')[1],

pull_number: ${{ github.event.number }},

per_page: 100,

});

const { owner, repo } = context.repo;

const pull_number = context.issue.number;

const commitsResponse = await github.paginate("GET /repos/{owner}/{repo}/pulls/{pull_number}/commits", {

owner,

repo,

pull_number,

per_page: 100

});

alechkos · 2024-07-07T15:46:08Z

.github/workflows/automerge-for-humans-merging.yml

+
+            await getCoAuthors();


Correct way to set the output in the Get List of authors step:

Suggested change

await getCoAuthors();

const coAuthors = await getCoAuthors();

core.setOutput("value", coAuthors);

implemment pagination

6a98c15

Gmin2 requested review from derberg, quetzalliwrites, fmvilas, KhudaDad414 and asyncapi-bot-eve as code owners December 17, 2023 09:24

github-actions bot reviewed Dec 17, 2023

View reviewed changes

KhudaDad414 requested changes Dec 18, 2023

View reviewed changes

added the co-authored by to next line

a4bda30

Gmin2 requested a review from KhudaDad414 January 14, 2024 10:48

KhudaDad414 requested changes Jan 15, 2024

View reviewed changes

done the reviewed changes

7873214

Gmin2 requested a review from KhudaDad414 January 15, 2024 17:02

KhudaDad414 previously approved these changes Jan 16, 2024

View reviewed changes

derberg requested changes Feb 21, 2024

View reviewed changes

cleanup

322078e

Gmin2 dismissed KhudaDad414’s stale review via 322078e March 11, 2024 21:24

Gmin2 requested a review from derberg March 11, 2024 21:26

derberg reviewed Mar 27, 2024

View reviewed changes

.github/workflows/automerge-for-humans-merging.yml Outdated Show resolved Hide resolved

Gmin2 and others added 2 commits March 28, 2024 20:22

removed install dependencies strep

efbeb9d

Merge branch 'master' into co-commit

1e5f6c1

tatality-lgtm reviewed Apr 18, 2024

View reviewed changes

alechkos suggested changes Jul 7, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: implemment pagination #266

ci: implemment pagination #266

Gmin2 commented Dec 17, 2023 •

edited

Loading

github-actions bot left a comment

KhudaDad414 left a comment

Gmin2 commented Dec 18, 2023 •

edited

Loading

smoya commented Dec 18, 2023

Gmin2 commented Dec 18, 2023

derberg commented Dec 18, 2023

smoya commented Dec 19, 2023

Gmin2 commented Dec 21, 2023

KhudaDad414 commented Dec 22, 2023

Gmin2 commented Jan 14, 2024 •

edited

Loading

Gmin2 commented Jan 15, 2024

KhudaDad414 left a comment

Gmin2 commented Jan 21, 2024

derberg left a comment

Gmin2 commented Feb 28, 2024

derberg commented Mar 11, 2024

Gmin2 commented Mar 11, 2024

Gmin2 commented Mar 11, 2024

derberg commented Apr 18, 2024

tatality-lgtm Apr 18, 2024

alechkos left a comment

alechkos Jul 7, 2024

alechkos Jul 7, 2024

-            await getCoAuthors();
+            const coAuthors = await getCoAuthors();
+            core.setOutput("value", coAuthors);

ci: implemment pagination #266

Are you sure you want to change the base?

ci: implemment pagination #266

Conversation

Gmin2 commented Dec 17, 2023 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

KhudaDad414 left a comment

Choose a reason for hiding this comment

Gmin2 commented Dec 18, 2023 • edited Loading

smoya commented Dec 18, 2023

Gmin2 commented Dec 18, 2023

derberg commented Dec 18, 2023

smoya commented Dec 19, 2023

Gmin2 commented Dec 21, 2023

KhudaDad414 commented Dec 22, 2023

Gmin2 commented Jan 14, 2024 • edited Loading

Gmin2 commented Jan 15, 2024

KhudaDad414 left a comment

Choose a reason for hiding this comment

Gmin2 commented Jan 21, 2024

derberg left a comment

Choose a reason for hiding this comment

Gmin2 commented Feb 28, 2024

derberg commented Mar 11, 2024

Gmin2 commented Mar 11, 2024

Gmin2 commented Mar 11, 2024

derberg commented Apr 18, 2024

tatality-lgtm Apr 18, 2024

Choose a reason for hiding this comment

alechkos left a comment

Choose a reason for hiding this comment

alechkos Jul 7, 2024

Choose a reason for hiding this comment

Simplification and correction of the way to access the repo information:

alechkos Jul 7, 2024

Choose a reason for hiding this comment

Correct way to set the output in the Get List of authors step:

Gmin2 commented Dec 17, 2023 •

edited

Loading

Gmin2 commented Dec 18, 2023 •

edited

Loading

Gmin2 commented Jan 14, 2024 •

edited

Loading

Correct way to set the output in the `Get List of authors` step: