refactor: unify styling #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
added
enhancement
fmvilas
requested changes
Apr 12, 2021
|
@fmvilas I moved the styles to components files :) Could you check again? I also moved those that are repeated, such as for buttons, because you are right that it is better to think about theming in the next cycles. |
|
Kudos, SonarCloud Quality Gate passed!
|
fmvilas
approved these changes
Apr 14, 2021
|
🎉 This PR is included in version 0.21.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Unify styling in component with HTML-Templates styling:
Info,Server,Operation,Message,Schemacomponentspostcss,tailwindetc. The rest of the code is converting inline styles/classes into mixed classes.Examples:
Info:
Server
Operation
Message
Related issue(s)
Part of asyncapi/shape-up-process#86