Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: infer types in proper way and add tests #332

Merged
merged 8 commits into from
May 17, 2021
Merged

refactor: infer types in proper way and add tests #332

merged 8 commits into from
May 17, 2021

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented May 5, 2021 •
edited
Loading

Description

Changes proposed in this pull request:

Infer types in proper way:

  • handle true/false schemas,
  • infer types from keywords and from enum,
  • handle empty schema,
  • update bump.yaml workflow
    Add missed tests for helpers (and also fix some bugs).

@magicmatatjahu magicmatatjahu added the area/library Related to all activities around Library package label May 5, 2021
@magicmatatjahu magicmatatjahu mentioned this pull request May 6, 2021
Merged
@magicmatatjahu magicmatatjahu force-pushed the next-branches/improve-inferring-types branch from 9414eb6 to e9c5306 Compare May 7, 2021 11:42
jonaslagoni
jonaslagoni reviewed May 12, 2021
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only had a few questions and suggestions 😄

library/src/helpers/__tests__/schema.test.ts Show resolved Hide resolved
library/src/helpers/__tests__/schema.test.ts Show resolved Hide resolved
library/src/helpers/__tests__/schema.test.ts Show resolved Hide resolved
library/src/helpers/__tests__/schema.test.ts Show resolved Hide resolved
library/src/helpers/schema.ts Outdated Show resolved Hide resolved
library/src/helpers/__tests__/schema.test.ts Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu
Copy link
Member Author

@jonaslagoni I added missed tests :)

@magicmatatjahu
Copy link
Member Author

@jonaslagoni Thanks :)

@magicmatatjahu magicmatatjahu changed the title fix: infer types in proper way and add tests refactor: infer types in proper way and add tests May 13, 2021
@magicmatatjahu magicmatatjahu merged commit 3517888 into asyncapi:next May 17, 2021
@magicmatatjahu magicmatatjahu deleted the next-branches/improve-inferring-types branch May 17, 2021 06:48
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

Assignees
No one assigned
Labels
area/library Related to all activities around Library package released on @next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicmatatjahu @asyncapi-bot @jonaslagoni