Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render missed parts for operations and render spec id #345

Merged
merged 1 commit into from
May 19, 2021

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented May 18, 2021

Description

Changes proposed in this pull request:

Render missed parts for operation:

  • operationId
  • externalDocs

Render id of spec.

ID:
image

Operation:
image

Related issue(s)
Part of #63

@magicmatatjahu magicmatatjahu added area/library Related to all activities around Library package enhancement New feature or request labels May 18, 2021
@sonarcloud
Copy link

sonarcloud bot commented May 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu magicmatatjahu changed the title chore: render missed parts for operations and render spec id feat: render missed parts for operations and render spec id May 19, 2021
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 1 comment, but, where are the tests? 🧐

playground/src/specs/streetlights.ts Show resolved Hide resolved
@magicmatatjahu
Copy link
Member Author

Only 1 comment, but, where are the tests? 🧐

We haven't integrated test framework for React.

@jonaslagoni
Copy link
Member

We haven't integrated test framework for React.

I see jest is already and a few tests have already been added, shouldn't take you long to test the new output i.e. find operation id and externalDocs and the document id. But of course, features take a little longer to create.

You have to start eventually, so why not this PR? 🤔

@magicmatatjahu
Copy link
Member Author

magicmatatjahu commented May 19, 2021

I see jest is already and a few tests have already been added, shouldn't take you long to test the new output i.e. find operation id and externalDocs and the document id. But of course, features take a little longer to create.

Testing normal TS function isn't this same as testing React, it doesn't like testing html as string and make some regex. Also we will rewrite component again in near future, when we will have a designer and therefore I don't want to test every part of a component.

@jonaslagoni
Copy link
Member

Testing normal TS function isn't this same as testing React, it doesn't like testing html as string and make some regex. Also we will rewrite component again in near future, when we will have a designer and therefore I don't want to test every part of a component.

Okay 🙂

@magicmatatjahu magicmatatjahu merged commit 0371914 into asyncapi:next May 19, 2021
@magicmatatjahu magicmatatjahu deleted the render-missed-parts branch May 19, 2021 13:38
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/library Related to all activities around Library package enhancement New feature or request released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants