Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changing codeowners of anypointmq binding #185

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

GeraldLoeffler
Copy link
Collaborator

Description

@GeraldLoeffler has resigned from Salesforce and therefore wants to transition ownership of the binding for Anypoint MQ (a Salesforce/MuleSoft product) to volunteers who are still Salesforce employees. Mihael Bosnjak (@mihaelmulesoft) and Jose Estefania Aulet (@jestefaniaaulet) have kindly come forward forward to co-own this binding.

Changing CODEOWNERS file accordingly.

@GeraldLoeffler has resigned from Salesforce and therefore wants to transition ownership of the binding for Anypoint MQ (a Salesforce/MuleSoft product) to volunteers who are still Salesforce employees. Mihael Bosnjak (@mihaelmulesoft) and Jose Estefania Aulet (@jestefaniaaulet) have kindly come forward forward to co-own this binding.
Changing `CODEOWNERS` file accordingly.
@M3lkior
Copy link
Contributor

M3lkior commented Feb 10, 2023

Hi @GeraldLoeffler; i think that @mihaelmulesoft and @jestefaniaaulet should meet the AsyncAPI community and works one some first PRs before becoming maintainer of this repository, no ?

@char0n
Copy link
Collaborator

char0n commented Feb 12, 2023

@derberg @fmvilas what's the policy and guidance in this situations? Is the code-ownership something that can assigned/inherited (given that there are volunteers)? IMHO this needs your input.

retaining @GeraldLoeffler as a 3rd co-owner of /anypointmq
Copy link
Member

derberg commented Feb 14, 2023

We do not have any official standard approach here, only recommendations.

The only thing that official Charter tells us is A Contributor may become a Committer of a given Project’s repository by majority approval of the repository Committers.

So it is up to us (bindings repo maintainers) to define what criteria we take into account to accept someone as maintainer.

And yes, the general rule of thumb is that you first contribute so later you can become a maintainers. The problem is that it is super easy on a tool level, where some additional work can be easily generated, so potential maintainer can first contribute. It is even easier on a spec level where we have regular releases, release process so it is easier for contributors to contribute and long term become a maintainer.

With bindings, it is not that easy, as bindings is basically a set of independent micro-specs for different protocols, that are not changed very often:

  • it is hard to find a set of starter issues that maintainer-candidate could do first
  • we do not have any practice here on how changing of maintainers should work, as we never did it before

should meet the AsyncAPI community

totally agree, joining Slack and #introduction channel would be a great start, maybe even community meeting (or spec 3.0 meeting)

@GeraldLoeffler is there anything in the current anypoint binding that requires some work that candidates could do? except of #182 that will soon generate some work for maintainers

It is a start of a very good discussion that we later need to document here as new version of https://github.com/asyncapi/bindings/blob/master/CONTRIBUTING.md (maybe that could be also done by the candidates)

@GeraldLoeffler
Copy link
Collaborator Author

no @derberg , there is no obvious outstanding work to be done on the current binding. But maybe @mihaelmulesoft and @jestefaniaaulet will will have some ideas once they look into it in detail.

also, to ease the transition away from me, I can offer to mentor their work on the first 1 or 2 PRs that they will work on - whenever that is.

Copy link
Member

derberg commented Feb 16, 2023

Would be good if @mihaelmulesoft and @jestefaniaaulet could join this PR and introduce

@derberg
Copy link
Member

derberg commented Mar 29, 2023

@GeraldLoeffler can you check with @mihaelmulesoft and @jestefaniaaulet. Maybe they need a call and some onboarding. I'm happy to help.

@mboss37
Copy link
Collaborator

mboss37 commented Mar 30, 2023

@derberg We already had a nice onboarding session with Gerald. Happy and ready to support working on the anypointmq bidnings

@derberg
Copy link
Member

derberg commented Jul 27, 2023

@GeraldLoeffler @mboss37 since @jestefaniaaulet is not active here, nor in the #203 I suggest he is not yet added to codeowners. We need people that are responsive that we can rely on.

@derberg
Copy link
Member

derberg commented Oct 11, 2023

removed @jestefaniaaulet for now as per my previous comment

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated GH handle for Mihael to mboss37

@derberg
Copy link
Member

derberg commented Oct 11, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 6a3537d into master Oct 11, 2023
7 checks passed
@asyncapi-bot asyncapi-bot deleted the GeraldLoeffler-codeowners-change branch October 11, 2023 16:28
@derberg
Copy link
Member

derberg commented Oct 11, 2023

@mboss37 you should get an invite to be a maintainer of the repo. I also sent invite to the organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants