Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapt MQTT bindings to v3 #205

Merged
merged 5 commits into from
Jul 25, 2023

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Jun 13, 2023

Description
This PR adapts the MQTT bindings to v3. This first round of review is just for the general structure changes.

TODO right before final review:

  • Adapt examples, if any that contain v2 structure.
  • Figure out which version change this constitutes

TODO after merge:

  • Adapt schema files in spec-schema-repo

Related issue(s)
Related to #182

@jonaslagoni jonaslagoni changed the base branch from master to next-major-spec June 22, 2023 10:23
@jonaslagoni jonaslagoni changed the title feat!: adapt MQTT bindings to v3 feat: adapt MQTT bindings to v3 Jun 22, 2023
mqtt/README.md Outdated Show resolved Hide resolved
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
@jonaslagoni jonaslagoni requested a review from fmvilas June 26, 2023 19:18
Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonaslagoni
Copy link
Member Author

Thanks folks 👍

@jonaslagoni
Copy link
Member Author

/rtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants