Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Glee tutorial template #887

Merged
merged 7 commits into from
Nov 21, 2023
Merged

feat: add Glee tutorial template #887

merged 7 commits into from
Nov 21, 2023

Conversation

fmvilas
Copy link
Member

@fmvilas fmvilas commented Nov 13, 2023 •
edited
Loading

Description

It adds the --template (-t) option to the asyncapi new glee and asyncapi new project commands. It let's you choose which template to use to generate the Glee project.

I'm also providing a new template to use for the Code Generation tutorial we'll have on the website after releasing v3.

TODO
  • Upgrade package.json of each template so they use the latest Glee release.

@fmvilas fmvilas mentioned this pull request Nov 14, 2023
Merged
2 tasks
Souvikns
Souvikns previously approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@Souvikns Souvikns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both asyncapi new glee and asyncapi new project create a glee project, still should we have both commands, doesn't it create confusion?

@derberg
Copy link
Member

derberg commented Nov 16, 2023

asyncapi new project can definitely be removed

as if it comes to the requirements for this PR, the template from this PR is not implementing req/reply so why waiting for new glee features?

@fmvilas
Copy link
Member Author

fmvilas commented Nov 21, 2023

as if it comes to the requirements for this PR, the template from this PR is not implementing req/reply so why waiting for new glee features?

That's definitely not needed. I removed it. I was experiencing an error that I thought it was caused by the req/reply PR but was actually caused by asyncapi/glee#589.

@fmvilas fmvilas marked this pull request as ready for review November 21, 2023 10:52
@fmvilas
Copy link
Member Author

fmvilas commented Nov 21, 2023

Regarding asyncapi new project, I created this issue: #913.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fmvilas
Copy link
Member Author

fmvilas commented Nov 21, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 7ab61ba into asyncapi:master Nov 21, 2023
11 checks passed
@fmvilas fmvilas deleted the add-tutorial-example branch November 21, 2023 11:11
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Souvikns Souvikns Souvikns approved these changes

@derberg derberg derberg approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmvilas @derberg @asyncapi-bot @Souvikns