fix: terraform setup added #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoandmatrix
requested review from
quetzalliwrites,
derberg,
asyncapi-bot-eve and
thulieblack
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
neoandmatrix
force-pushed
the
terraform-fix
branch
from
49fbf8a to
87869d7
Compare
|
Hey @Shurtu-gal any reviews or suggestions for these changes? |
|
/update |
|
@neoandmatrix we need for a codeowner to approve it though. |
|
@derberg @quetzalliwrites @thulieblack Please take a look at this PR. Thanks! 👋 |
neoandmatrix
force-pushed
the
terraform-fix
branch
from
c82e379 to
b184564
Compare
|
@thulieblack you would have to approve the workflow as well 😓 |
|
which workflow? |
|
some workflows maintainers need to approve if there is a first PR from contributor I just clicked 
|
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the necessary changes required in the new
ubuntu-latestimage used for the workflow to setup terraform.As previously discussed with @Shurtu-gal in the issue #1658 the used action in the PR is
hashicorp/setup-terraform@v3 actionand i have tested it by creating a slack workspace and running the workflow similar to one mentioned in the issue.Here is the repository for same.
Related issue(s)
Resolves #1658
@Shurtu-gal please review and provide feedback on the PR.
Thanks.