Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add asyncapi events scheduling automation #308

Merged
merged 13 commits into from
Apr 20, 2022

Conversation

derberg
Copy link
Member

@derberg derberg commented Mar 31, 2022

Description

This PR introduces fully automated meetings scheduling. There are some manual steps though that you need to perform once you start the meeting and after it is finished.

  • current automation based on custom JS code for creating GH Issue content got removed and replaced with "templated markdown" approach. In other words, files like .github/workflows/event_issue_templates/meetings/community.js got replaced with files like .github/workflows/create-event-helpers/issues_templates/community.md
  • workflows per event got simplified, redundancy got removed by introducing reusable workflow: .github/workflows/create-event-workflow-reusable.yml
  • added new workflow for handling meeting cancelation (removing entry from google calendar)
  • we deprecate https://groups.google.com/u/1/g/asyncapi-users and move current members to newsletter subscribers (with Mailchimp) as this is where we will send info about upcoming meetings every Friday.
  • we deprecate current AsyncAPI calendar and replace it with new one
  • except for existing "meeting issues creation" we now also have "zoom meeting creation" and also "google calendar entry creation"
  • introduces a concept of ad hoc meeting. It means meeting that needs to be organized with the community to discuss some specific topic not related to one of the existing meetings. Let's say you want to discuss "many meanings of asyncapi document" @jonaslagoni 😉
  • @fmvilas I added automation for Thinking Out Loud
  • @alequetzalli I added new documentation and I did it in FAQ style as this kinda felt like the best way to structure all the information about meeting scheduling

TODO:

huge thanks to

  • @sudoshreyansh for cracking the Google Calendar API for me and providing code samples
  • @Krishks369 for cracking the Zoom API for me and providing code samples

☝🏼 you folks made it possible to speed up the work on this PR by a 💯 Thanks 🍻

In case you folks want to see some examples, check out this tweet and retweets where I was sharing examples on how it looks/works

Related issue(s)
Resolves #245

fmvilas
fmvilas previously approved these changes Apr 4, 2022
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding Thinking Out Loud 🙏

Looks good to me 🚀

@derberg
Copy link
Member Author

derberg commented Apr 5, 2022

ok folks, https://asyncapi.com/newsletter is now public, and I update PR. Ready for final review @alequetzalli

@jonaslagoni all good from your side? in regards to full scheduling automation with some cron job....are you still into it? I personally prefer to schedule community meetings manually as sometimes they might be canceled cause of holidays.

Comment on lines 73 to 75
## Notes

tbd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Notes
tbd

Seems odd, like a mistake to have the tbd left in there..

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is intentional.
once issue is created, there are no notes, thus tbd - to be done/delivered. How can we do it differently? more details sentence like "Notes are provided after the meeting?"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you feel about writing instead: Add notes here after the meeting.

(Can they add notes later, or did I completely misunderstand how it works? 😆 )

@derberg

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you understood it right, we never write them real-time but always after meeting, a kind of summary. I updated PR with your suggestion, thanks!!!

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left my review, @derberg! 👯

Co-authored-by: Alejandra Quetzalli  <alejandra.quetzalli@postman.com>
### How can I become a host?

Once your `Regular` meeting gets approved, contact `Fran Mendez` so that he can give you access to all required tools.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmvilas I assume you saw this during the review and you are fine with it 😄 you are the only one that can add to Zoom, so it was natural for me that you will handle other accounts to, so there is just one person that controls that and not an octopus 😄

all accounts are mentioned in What do I need to schedule a meeting?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's fine. We can always change it 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

translation for community:
change it is a nice word for find another victim 😆

@fmvilas you can always write a script for it 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know me too well 😅

@derberg
Copy link
Member Author

derberg commented Apr 7, 2022

@alequetzalli thanks so much for great and detailed review

what is your take on FAQ like documentation approach?

btw, I'm surprised there were no suggestions to add emojis, after the Community Meeting I braced myself for emojis suggestions flood 😆

@quetzalliwrites
Copy link
Member

btw, I'm surprised there were no suggestions to add emojis, after the Community Meeting I braced myself for emojis suggestions flood 😆

I should downvote this comment for the emoji quip 😛 hahaha

what is your take on FAQ like documentation approach?

I liked it! I think it was perfect for the README docs you added there, made perfect sense.

quetzalliwrites
quetzalliwrites previously approved these changes Apr 7, 2022
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hitting approve in case you decide to stick with tbd under the Notes section. Everything else LGTM 🚀 🌟 ⭐

@derberg

@derberg
Copy link
Member Author

derberg commented Apr 11, 2022

@alequetzalli I made small change replacing tbd, please have a look

@derberg
Copy link
Member Author

derberg commented Apr 12, 2022

@alequetzalli @fmvilas I assume you are ok, we will merge this week and I start communication with the community about deprecating https://groups.google.com/u/1/g/asyncapi-users and migrating them to MailChimp newsletter. I also explained it last week during community meeting and there were no objections during and after the meeting 💪🏼

name: Schedule Lets talk about contributing Meeting

on:
workflow_dispatch:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonaslagoni I just noticed your comment that you would actually like to have a cron job

After googling a bit I figured there is no way to have bi-weekly cron other than https://crontab.guru/#30_1_1,15__
This is not most optimal as it is hard to figure what is exactly the time of the meeting. With hour it is easy as it is fixed.

The only option I see is some more complex code, where we pick from Google Calendar the last 3.0 meeting and then add 2 weeks to it 🤷🏼 if you still want it, I suggest we do it in followup PR to not complicated this one more that it is needed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@derberg
Copy link
Member Author

derberg commented Apr 20, 2022

ok, merging, let's see what is broken and expect followup PR 😆 😞 😉

@derberg
Copy link
Member Author

derberg commented Apr 20, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 7536466 into asyncapi:master Apr 20, 2022
@derberg derberg deleted the meetingsautomation branch April 20, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meeting as a Service
5 participants