Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Akshat Nema as TSC Member #430

Merged
merged 5 commits into from
Aug 16, 2022
Merged

Conversation

akshatnema
Copy link
Member

Description

  • Added my details in TSC_members.json file and updated repos for @mcturco.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@mcturco
Copy link
Member

mcturco commented Jul 29, 2022

Thank you 😄

fmvilas
fmvilas previously approved these changes Jul 29, 2022
@quetzalliwrites
Copy link
Member

hey @akshatnema, this PR only lists 3 people but the TSC is comprised of over 20 people. :)

When I requested to be submitted to the TSC I had to ensure my PR included all TSC members. I think you should prob make sure to do the same :)

@akshatnema
Copy link
Member Author

hey @akshatnema, this PR only lists 3 people but the TSC is comprised of over 20 people. :)

@alequetzalli I think you are noticing the changes in the TSC file. There are all the members of TSC in the file and I just added my details in alphabetical order.

@quetzalliwrites
Copy link
Member

Oh no, hehehe That's not what I am referring to. I'm talking about the reviewers section 😄✌🏽.

As in, you add more TSC members to "review the PR" and accept it too. ( you know, to keep it fair so that more TSC members vote and are aware of awesome new changes to the list... it's also more fair to always add the community of TSC members and not just a few folks in it that we work with the most often.. or at least, that is why/how I had to do it for mine 😀)

@akshatnema
Copy link
Member Author

As in, you add more TSC members to "review the PR" and accept it too.

@alequetzalli ohh I got it 😅. The point is I can't add more members to review this PR as I'm not the maintainer of this repo. Can I tag all tsc members here so they can be notified on Slack to review this PR?

@quetzalliwrites
Copy link
Member

quetzalliwrites commented Aug 1, 2022

Oh, I had no idea! that sucks 😂, here let me do it for you + I will also mention get this as a TSC Slack bot announcement 📣 🎉 in Slack for that part too 👍

@quetzalliwrites quetzalliwrites requested a review from a team August 1, 2022 18:02
@quetzalliwrites
Copy link
Member

@asyncapi/tsc_members Don't forget to vote 🗳 for a new TSC member submission! 🎉 Akshat is doing a lot of super needed contributions to /website repo and thus got submitted.

(also, this PR by him made sure to update the contributions to more repos that Missy is now maintaining!)

ron-debajyoti
ron-debajyoti previously approved these changes Aug 1, 2022
Copy link
Contributor

@ron-debajyoti ron-debajyoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes yes !!

quetzalliwrites
quetzalliwrites previously approved these changes Aug 1, 2022
mcturco
mcturco previously approved these changes Aug 1, 2022
Copy link
Member

@mcturco mcturco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

aayushmau5
aayushmau5 previously approved these changes Aug 2, 2022
Copy link
Member

@aayushmau5 aayushmau5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! 🚀

jonaslagoni
jonaslagoni previously approved these changes Aug 6, 2022
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! 🎉

Copy link
Member

@BOLT04 BOLT04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @akshatnema 🙂

@fmvilas
Copy link
Member

fmvilas commented Aug 15, 2022

IIRC, @akshatnema is already a TSC member because he is a Code Owner of the website repo. Therefore, we don't need to vote but just update the list.

@derberg derberg changed the title added Akshat Nema as TSC Member docs: add Akshat Nema as TSC Member Aug 16, 2022
@derberg derberg merged commit 4c8acf0 into asyncapi:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants