-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Akshat Nema as TSC Member #430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
Thank you 😄 |
hey @akshatnema, this PR only lists 3 people but the TSC is comprised of over 20 people. :) When I requested to be submitted to the TSC I had to ensure my PR included all TSC members. I think you should prob make sure to do the same :) |
@alequetzalli I think you are noticing the changes in the TSC file. There are all the members of TSC in the file and I just added my details in alphabetical order. |
Oh no, hehehe That's not what I am referring to. I'm talking about the reviewers section 😄✌🏽. As in, you add more TSC members to "review the PR" and accept it too. ( you know, to keep it fair so that more TSC members vote and are aware of awesome new changes to the list... it's also more fair to always add the community of TSC members and not just a few folks in it that we work with the most often.. or at least, that is why/how I had to do it for mine 😀) |
@alequetzalli ohh I got it 😅. The point is I can't add more members to review this PR as I'm not the maintainer of this repo. Can I tag all tsc members here so they can be notified on Slack to review this PR? |
Oh, I had no idea! that sucks 😂, here let me do it for you + I will also mention get this as a TSC Slack bot announcement 📣 🎉 in Slack for that part too 👍 |
@asyncapi/tsc_members Don't forget to vote 🗳 for a new TSC member submission! 🎉 Akshat is doing a lot of super needed contributions to (also, this PR by him made sure to update the contributions to more repos that Missy is now maintaining!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes yes !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome! 🎉
ea71c33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @akshatnema 🙂
IIRC, @akshatnema is already a TSC member because he is a Code Owner of the website repo. Therefore, we don't need to vote but just update the list. |
Description