-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add new maintainers.yaml file with tsc_members.json data #720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can merge this PR during the maintainership, even if not all automation is in place, but that requires also update to:
- https://github.com/asyncapi/community/blob/master/Become-maintainer-in-existing-project.md
- https://github.com/asyncapi/community/blob/master/.github/workflows/msg-to-new-member-pr-merged.yml
and also you need to change
- https://github.com/asyncapi/community/blob/master/.github/workflows/validate-tsc-members.yml
- https://github.com/asyncapi/community/blob/master/.github/workflows/tsc_members_validator/schema.json
yes 🤯 I was talking about validation of the file against json schema, that it would be nice.....and I just figured that we already have it 🤯 so just small adjustment is needed, new isTscMember
filed added to json schema, and overall naming change in the workflow
@derberg, I have updated the workflow, and now it triggers when changes are made to Additionally, I have updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good quality updates to the PR 👏🏼
left few minors
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
…nto migrate-json-to-yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🚀
…nto migrate-json-to-yaml
/rtm |
Description
This PR adds a new YAML file named
MAINTAINERS.yaml
. TheMAINTAINERS.yaml
file includes the data from the existingtsc_members.json
file, but in YAML format. It also includes an update to theupdate-website-tsc.yaml
workflow to accept the new YAML file instead of the old JSON file.Additionally, the conversion from YAML to JSON is being done using Python.
I have tested this locally to ensure that the conversion works correctly. Here is the link to the local test results: https://github.com/14Richa/testRepo/actions/runs/5421542255/jobs/9857107425
Related issue(s)
#210