Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQS Extension Supporting FIFO & Standard Queues. #8

Merged
merged 4 commits into from
Apr 29, 2020
Merged

SQS Extension Supporting FIFO & Standard Queues. #8

merged 4 commits into from
Apr 29, 2020

Conversation

Paul-T-AU
Copy link
Contributor

AWS SQS Extension

  • Support for FIFO Queues, with Group ID & Dedupe
  • Standard Queue definition
  • Sub & Pub config example

Related issue(s)

See also Issue # 11 Bindings Feature Request

@Paul-T-AU
Create 0.1.0.yml
deb445b 
Initial commit of SQS extension supporting both FIFO & Standard queues.
@Paul-T-AU
Update 0.1.0.yml
829655e 
Updated Examples and typo change for SQS Initial commit
fmvilas
fmvilas requested changes Apr 27, 2020
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Paul-T-AU! It's looking great. Just added a minor comment but overall this looks good to me 👍

extensions/sqs/0.1.0.yml Outdated Show resolved Hide resolved
Paul-T-AU and others added 2 commits April 29, 2020 08:27
@Paul-T-AU @fmvilas
Update extensions/sqs/0.1.0.yml
4f888ff 
Correction of type.

Co-Authored-By: Fran Méndez <fmvilas@gmail.com>
@Paul-T-AU
Update 0.1.0.yml
109f28f 
Add Contact block.

#10

Add Tags to help search/filtering.

#9
@Paul-T-AU Paul-T-AU requested a review from fmvilas April 29, 2020 01:45
fmvilas
fmvilas approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great move adding tags and contact already. Thanks, Paul!

@fmvilas fmvilas merged commit cb27acc into asyncapi:master Apr 29, 2020
@fmvilas fmvilas mentioned this pull request Apr 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Paul-T-AU @fmvilas