feat: move template config to package.json #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derberg
commented
May 20, 2020
| @@ -166,9 +162,9 @@ class Generator { | |||
| this.templateContentDir = path.resolve(this.templateDir, TEMPLATE_CONTENT_DIRNAME); | |||
| this.configNunjucks(); | |||
| await this.loadTemplateConfig(); | |||
| validateTemplateConfig(this.templateConfig, this.templateParams, asyncapiDocument); | |||
There was a problem hiding this comment.
I changed the order of calling validation and removed it from here https://github.com/asyncapi/generator/pull/349/files#diff-b58e2f1cee2acff55355343774e6d576L646 as I could not come up with an explanation why we were calling validation twice.
also, it is no longer async as I think it should never be
|
Kudos, SonarCloud Quality Gate passed!
|
fmvilas
approved these changes
May 21, 2020
|
🎉 This PR is included in version 0.50.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.tp-config.jsonis removed and config should be now done undergeneratorprops in thepackage.jsonfilevalidateTemplateConfigas too complex function. Because I was working on config here so I took the liberty to refactor it and move to a separate file + add tests that cover every validation optionMIGRATION
This is a breaking change. Migrate by removing current config file and moving its content to
package.jsonand bumping version of supported generator to the one released with this PR.Example -> asyncapi/nodejs-template#15
Related issue(s)
Resolves #228