Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: start supporting spec 2.4 by using latest generator version 1.9.5 #236

Closed
wants to merge 3 commits into from
Closed

Conversation

victormartingarcia
Copy link
Contributor

Description
Bump @asyncapi/generator dependency to 1.9.5 on packages.json

Related issue(s)
Resolves #232

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@victormartingarcia victormartingarcia changed the title Support for 2.4 feat: start supporting spec 2.4 by using latest generator version 1.9.5 Aug 17, 2022
@derberg
Copy link
Member

derberg commented Aug 18, 2022

@victormartingarcia hey, I see you created PR from master that probably was not synchronized with upstream master, and this is why this PR is not only introducing changes in Dockerfile but also package files again.

Best way to solve it is to prepare your fork using https://github.com/asyncapi/community/blob/master/git-workflow.md, especially if you plan further contributions. Then create a new PR

@victormartingarcia victormartingarcia closed this by deleting the head repository Aug 18, 2022
@victormartingarcia
Copy link
Contributor Author

Sorry about that!

I created a new PR #237 following the contribution guidelines above. I had to downgrade to node 14 for making it work on my local machine, but mysteriously it is falling on the pipeline: https://github.com/asyncapi/github-action-for-generator/runs/7893944814?check_suite_focus=true

Any ideas how to fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 2.4.0 not supported
2 participants