Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move from node 16 to 14 because of failing docker build #237

Merged
merged 4 commits into from
Aug 18, 2022
Merged

fix: move from node 16 to 14 because of failing docker build #237

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc94f3f
omit installing devDependencies on docker build
victormartingarcia Aug 18, 2022
58b34b0
downgrading to node 14 and omitting dev dependencies build
victormartingarcia Aug 18, 2022
61d249b
downgrade to node 14
victormartingarcia Aug 18, 2022
c1f09e4
Install all dependencies on docker build
victormartingarcia Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
FROM node:16 as builder
FROM node:14 as builder

COPY ./ /app
WORKDIR /app

RUN npm install && npm run package

FROM node:16-alpine
FROM node:14-alpine

# We need to copy entire node modules as some dependencies (@npmcli/run-script) cannot be packaged
# We need to copy entire node modules as some dependencies (@npmcli/run-script) cannot be packaged
# and need to be used by dist as external dependency
COPY --from=builder /app/node_modules ./node_modules
COPY --from=builder /app/dist ./dist

ENTRYPOINT [ "node", "/dist/index.js" ]
ENTRYPOINT [ "node", "/dist/index.js" ]