fix: revert update puppeteer to 23.2.0 #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a1c77c3.
derberg
requested review from
fmvilas,
magicmatatjahu and
asyncapi-bot-eve
as code owners
|
magicmatatjahu
approved these changes
Sep 2, 2024
|
/rtm |
asyncapi-bot
deleted the
revert-668-feature/update-puppeterr-to-23.2.0
branch
|
🎉 This PR is included in version 2.3.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #668
It should not be done without getting #615 first done.
we can upgrade puppeteer because generator v2 do not support old node - but we cannot do it without first updating template that it no longer supports old generator v1 - this must be done as a major release
fyi @bakasmarius