Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api version to v3 #168

Closed
wants to merge 1 commit into from

Conversation

AayushSaini101
Copy link

Resolve: #118

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

sonarcloud bot commented Jan 28, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@AayushSaini101 AayushSaini101 changed the title feat: Add api version to v3 feat: add api version to v3 Jan 28, 2024
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm not a code owner. A part of me doesn't believe it's that easy 😄 I hope it is! It would be mean we did a great job 😄

@derberg
Copy link
Member

derberg commented Feb 19, 2024

@AayushSaini101 did you test this change? I mean after just changing the version, did you try to run code generation with such change? I would be surprised if that is enough to make template support v3

@dalelane
Copy link
Collaborator

dalelane commented Mar 7, 2024

I think more is needed than this. I've tried to make a start in moving this forward in #186 but I still don't think the work is complete even with that.

@dalelane
Copy link
Collaborator

dalelane commented Mar 8, 2024

closing in favour of #186

@dalelane dalelane closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncAPI spec v3 support in Java Template
5 participants