Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable v3 support #360

Merged
merged 30 commits into from
Oct 9, 2023
Merged

feat: enable v3 support #360

merged 30 commits into from
Oct 9, 2023

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Aug 3, 2023 •
edited
Loading

Description

This PR contains the following changes:

  • Adds a new request/reply rendering (everything else in v3 is already supported)
  • Adds some new tests

Related issue(s)

Fixes #341
Blocked by asyncapi/generator#1017
Blocked by asyncapi/generator#1039
Blocked by asyncapi/generator-react-sdk#180

jonaslagoni
jonaslagoni commented Aug 11, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
jonaslagoni
jonaslagoni commented Aug 11, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@jonaslagoni jonaslagoni marked this pull request as ready for review August 11, 2023 07:39
@jonaslagoni jonaslagoni mentioned this pull request Aug 11, 2023
Merged
@jonaslagoni jonaslagoni mentioned this pull request Aug 29, 2023
Closed
@jonaslagoni jonaslagoni marked this pull request as draft August 30, 2023 13:02
@jonaslagoni jonaslagoni mentioned this pull request Sep 11, 2023
Merged
@jonaslagoni jonaslagoni marked this pull request as ready for review September 14, 2023 13:35
@fmvilas fmvilas mentioned this pull request Sep 14, 2023
Closed
2 tasks
@jonaslagoni
Copy link
Member Author

@magicmatatjahu @derberg @fmvilas its finally ready to be reviewed 😄

@jonaslagoni jonaslagoni mentioned this pull request Sep 29, 2023
Merged
fmvilas
fmvilas requested changes Oct 4, 2023
View reviewed changes
package.json Show resolved Hide resolved
test/components/Operations.test.js Outdated Show resolved Hide resolved
@jonaslagoni jonaslagoni mentioned this pull request Oct 6, 2023
Merged
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 81 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni
Copy link
Member Author

I have tried multiple approaches to make sonar ignore those rules, but I cant... So now you just need to ignore them in the review 🤷 They are unrelated to templates.

@jonaslagoni
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 269fb37 into asyncapi:master Oct 9, 2023
11 checks passed
@jonaslagoni jonaslagoni deleted the v3_update branch October 9, 2023 09:01
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AsyncAPI spec v3 support in markdown template
3 participants
@jonaslagoni @asyncapi-bot @fmvilas