Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dependency manager for Javascript #1041

Conversation

jonaslagoni
Copy link
Member

Description
This PR adds the new dependency manager alongside a few changes:

  • Allow the user to add dependencies for each model in the constraint and presets phase.
  • As a side effect of the implementation, this enables the user to selectively overwrite options so you do not have to create a new generator instance all the time.

These changes currently live on the dependency_-manager (wups) branch and are a WIP until all generators are adapted, that is why the tests are failing.

Related issue(s)
Read more about the change here: #947
Fixes: #851

@jonaslagoni jonaslagoni changed the base branch from master to dependency_-manager December 6, 2022 22:52
This reverts commit e458f56.
@jonaslagoni jonaslagoni removed the request for review from ron-debajyoti December 6, 2022 22:53
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonaslagoni jonaslagoni merged commit e0d99e7 into asyncapi:dependency_-manager Dec 8, 2022
@jonaslagoni jonaslagoni deleted the javascript_dependency_manager branch December 8, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give type constraint access to renderer
2 participants