Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dependency manager for Kotlin #1083

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Jan 19, 2023

Description
This PR adds the final piece to the puzzle (before releasing the feature) and adds the dependency manager to Kotlin.

This is a core Modelina feature replicated across all generators that enables a few things.

  1. It lets users add dependencies for models during the constraint phase, i.e. solving: Allow customizing of type mappings in renderers #546 (comment)
  2. It enables greater separation of logic for handling dependencies within one specific file instead of it being part of the renderer.
  3. Subsequently the architecture enables greater precision of rendering models where we now have 3 different levels of options: https://github.com/asyncapi/modelina/pull/1063/files#diff-72376d0b487d7231cf31959bf266f6aea098e899743bae02e36d176cef4db476

@LouisXhaferi like the rest of the champions, it's up to you to decide how involved you want to be with the core Modelina changes, it's perfectly fine to say you don't want to invest the time into reviewing these types of changes, just let us know ASAP so another core champion can review it 🙂 Otherwise, by default I assume you want to review it 🙂

@LouisXhaferi
Copy link
Contributor

Hey @jonaslagoni 👋🏻
I'll look at core topics as well and see how it fares! Will look at this PR in a couple of hours 🙏🏻

Copy link
Contributor

@LouisXhaferi LouisXhaferi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool feature 👍🏻
lgtm, if you clean up the couple unused imports and declarations.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonaslagoni jonaslagoni merged commit 3be5466 into asyncapi:dependency_-manager Jan 20, 2023
@jonaslagoni jonaslagoni deleted the feature/add_kotlin_dependency_manager branch January 20, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants