Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove double None from Pydantic preset #2181

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

black-snow
Copy link
Contributor

@black-snow black-snow commented Feb 14, 2025

@jonaslagoni not sure if you're the original author - could you review this? See #2174

Fixes #2174

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit fb77b2f
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/67b0cc1a84265c0008600e3d

@black-snow black-snow changed the title remove double None from Pydantic preset fix: remove double None from Pydantic preset Feb 14, 2025
jonaslagoni
jonaslagoni previously approved these changes Feb 15, 2025
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @black-snow

@jonaslagoni
Copy link
Member

@black-snow remember to update the examples npm run test:examples -- -u

@black-snow
Copy link
Contributor Author

black-snow commented Feb 15, 2025

Thanks @jonaslagoni,
examples/generate-python-pydantic-models/__snapshots__/index.spec.ts.snap updated

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13347103896

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 92.4%

Totals Coverage Status
Change from base Build 13336884503: -0.003%
Covered Lines: 6474
Relevant Lines: 6869

💛 - Coveralls

@jonaslagoni jonaslagoni merged commit 3e4227e into asyncapi:master Feb 17, 2025
16 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] generates broken Python code, default kwarg repeated
4 participants