Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: special cases in enum values for C# generator #559

Merged
merged 4 commits into from
Jan 4, 2022
Merged

fix: special cases in enum values for C# generator #559

merged 4 commits into from
Jan 4, 2022

Conversation

ron-debajyoti
Copy link
Contributor

Description
I used the helper function FormatHelpers similar to #497 to resolve for special characters in the enum renderer for C#. Also wrote down an additional test and updated the jest snapshot.

Related issue(s)
Fixes #503

github-actions[bot]
github-actions bot reviewed Jan 4, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@coveralls
Copy link

coveralls commented Jan 4, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1655363100

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 93.234%
Totals Coverage Status
Change from base Build 1654687343: 0.002%
Covered Lines: 2316
Relevant Lines: 2365
💛 - Coveralls

jonaslagoni
jonaslagoni requested changes Jan 4, 2022
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment 🙂 👍

test/generators/csharp/CSharpGenerator.spec.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jonaslagoni
jonaslagoni approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonaslagoni
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit ef4c0b7 into asyncapi:master Jan 4, 2022
@jonaslagoni
Copy link
Member

@all-contributors please add @ron-debajyoti for code, test

@allcontributors allcontributors bot mentioned this pull request Jan 4, 2022
Merged
@allcontributors
Copy link
Contributor

@jonaslagoni

I've put up a pull request to add @ron-debajyoti! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.40.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jonaslagoni jonaslagoni jonaslagoni approved these changes

Assignees
No one assigned
Labels
ready-to-merge released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Special cases in enum values fails to generate accurate enum keys for C# generator
4 participants
@ron-debajyoti @coveralls @jonaslagoni @asyncapi-bot