Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing sonarcloud duplication problems #570

Merged

Conversation

jonaslagoni
Copy link
Member

Description
This PR fixes duplication detection between generators, as fixing them, for now, introduces unnecessary complexity.

Related issue(s)
Related to #567 and #553

@jonaslagoni jonaslagoni changed the title refactor: fixing sonarcloud duplication problems ci: fixing sonarcloud duplication problems Jan 10, 2022
@coveralls
Copy link

coveralls commented Jan 10, 2022

Pull Request Test Coverage Report for Build 1678919154

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.33%

Totals Coverage Status
Change from base Build 1678226023: 0.0%
Covered Lines: 2351
Relevant Lines: 2400

💛 - Coveralls

@jonaslagoni jonaslagoni changed the title ci: fixing sonarcloud duplication problems chore: fixing sonarcloud duplication problems Jan 10, 2022
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I 🤞🏼 that it works as expected :)

@jonaslagoni
Copy link
Member Author

LGTM! I 🤞🏼 that it works as expected :)

Yea, lets see 🤞

@jonaslagoni jonaslagoni merged commit dc68646 into asyncapi:master Jan 10, 2022
@jonaslagoni jonaslagoni deleted the feature/fix_sonar_cloud_duplicates branch January 10, 2022 19:07
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.42.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants