Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: release version 1 #674

Merged
merged 206 commits into from
Jan 23, 2023
Merged

feat!: release version 1 #674

merged 206 commits into from
Jan 23, 2023

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Mar 8, 2022 •
edited
Loading

Description
This PR releases the next branch as master. If you are already using the newest next branch updating to master (once released) can be done without worry.

@jonaslagoni
refactor: add splitter (#676)
02fbb67
@jonaslagoni
refactor: add CommonModel conversion to MetaModel (#677)
e34866b
@jonaslagoni
refactor: add TypeScript constrainer (#683)
ea074f9
@jonaslagoni
refactor: add JavaScript constrainer (#693)
129b535
@jonaslagoni
refactor: add Go constrainer (#695)
1573780 
* Added go constraints

* Fixed type problems

* Fixed spelling mistake
@jonaslagoni
refactor: add C# constrainer (#696)
ad3d967 
* Add csharp constrainer

* Fixed spellingMistake
@jonaslagoni
refactor: add Java constrainer (#694)
9e43d27
@jonaslagoni
refactor: simplified constraints and type mapping (#725)
d179879
@jonaslagoni
refactor: update with master (#729)
e2df784
@jonaslagoni
refactor: convert CSharp to new constraint setup (#735)
f7a581f
@jonaslagoni
refactor: convert Go to new constraint setup (#732)
078bb98 
* Convert Go to the new setup

* Add extra test
@jonaslagoni
refactor: convert TS to new constraint setup (#736)
61abe6f
@jonaslagoni
refactor: convert JS to new constraint setup (#741)
e813203
@jonaslagoni
refactor: add object property model (#758)
2451e69
@jonaslagoni
chore: refactored model setup to support generators (#766)
129287c
@jonaslagoni
chore: refactored input processors (#767)
73ed585
@jonaslagoni
chore: refactored TypeScript and generator implementation (#765)
3d0a85d
@jonaslagoni jonaslagoni changed the title feat: release next feat!: release next Jun 17, 2022
@jonaslagoni jonaslagoni changed the title feat!: release next feat!: release next branch Jan 20, 2023
@coveralls
Copy link

coveralls commented Jan 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3986121227

  • 3607 of 3846 (93.79%) changed or added relevant lines in 197 files are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.2%) to 92.386%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/generators/AbstractGenerator.ts 26 27 96.3%
src/generators/dart/DartRenderer.ts 8 9 88.89%
src/generators/java/presets/CommonPreset.ts 29 30 96.67%
src/generators/kotlin/KotlinRenderer.ts 22 23 95.65%
src/generators/kotlin/presets/DescriptionPreset.ts 18 19 94.74%
src/generators/python/constrainer/EnumConstrainer.ts 29 30 96.67%
src/generators/rust/renderers/EnumRenderer.ts 33 34 97.06%
src/generators/typescript/TypeScriptGenerator.ts 55 56 98.21%
src/generators/typescript/constrainer/EnumConstrainer.ts 28 29 96.55%
src/generators/typescript/presets/DescriptionPreset.ts 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
src/generators/dart/presets/JsonSerializablePreset.ts 1 61.54%
src/generators/javascript/presets/CommonPreset.ts 1 79.73%
src/generators/typescript/presets/DescriptionPreset.ts 1 84.0%
src/generators/csharp/renderers/ClassRenderer.ts 3 77.19%
Totals Coverage Status
Change from base Build 3948257308: 0.2%
Covered Lines: 4725
Relevant Lines: 4984
💛 - Coveralls

@asyncapi-bot
Copy link
Contributor

Hello, @coveralls! 👋🏼

I'm Genie from the magic lamp. Looks like somebody needs a hand! 🆘

At the moment the following comments are supported in pull requests:

  • /ready-to-merge or /rtm - This comment will trigger automerge of PR in case all required checks are green, approvals in place and do-not-merge label is not added
  • /do-not-merge or /dnm - This comment will block automerging even if all conditions are met and ready-to-merge label is added
  • /autoupdate or /au - This comment will add autoupdate label to the PR and keeps your PR up-to-date to the target branch's future changes. Unless there is a merge conflict or it is a draft PR.

@jonaslagoni
Copy link
Member Author

Tagging all code owners (@magicmatatjahu, @LouisXhaferi, @leigh-johnson, @Samridhi-98, @ron-debajyoti), last chance to object to releasing v1.

Remember, we can always fix, add features and create another major version change again (that doesn't take a year to complete). Dont want to do something like this scale again 🙃 The only thing that changes with the move to version 1 is that we have to comply with this: https://github.com/asyncapi/modelina/tree/next#versioning-and-maintenance going forward 🙂

If no objections, this will be released on Monday the 23rd of January.

@jonaslagoni jonaslagoni changed the title feat!: release next branch feat!: release version 1 Jan 20, 2023
magicmatatjahu
magicmatatjahu previously approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Unlucky number 😆

@jonaslagoni
Copy link
Member Author

jonaslagoni commented Jan 20, 2023 •
edited
Loading

@magicmatatjahu didn't even see, do I have to add a file just for the sake of it? 😆

@magicmatatjahu
Copy link
Member

No, you don't need 😄

Samridhi-98
Samridhi-98 previously approved these changes Jan 20, 2023
View reviewed changes
LouisXhaferi
LouisXhaferi previously approved these changes Jan 20, 2023
View reviewed changes
leigh-johnson
leigh-johnson previously approved these changes Jan 20, 2023
View reviewed changes
@akshatnema @jonaslagoni
chore: added prettier config (#838)
6600a0b 
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
Co-authored-by: Jonas Lagoni <jonas-lt@live.dk>
@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 24 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni
Copy link
Member Author

jonaslagoni commented Jan 23, 2023 •
edited
Loading

@Samridhi-98 and/or @ron-debajyoti, I need another approval from you folks 🙂

@jonaslagoni jonaslagoni mentioned this pull request Jan 23, 2023
Closed
@jonaslagoni jonaslagoni merged commit a242f9b into master Jan 23, 2023
jonaslagoni added a commit to jonaslagoni/generator-model-sdk that referenced this pull request Jan 24, 2023
@jonaslagoni
Revert "feat!: release version 1 (asyncapi#674)"
f8d0042 
This reverts commit a242f9b.
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonaslagoni jonaslagoni mentioned this pull request Jan 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samridhi-98 Samridhi-98 Samridhi-98 approved these changes

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@LouisXhaferi LouisXhaferi LouisXhaferi left review comments

@leigh-johnson leigh-johnson leigh-johnson left review comments

@ron-debajyoti ron-debajyoti Awaiting requested review from ron-debajyoti

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.