Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rewrite go generator tests #808

Closed
wants to merge 11 commits into from
Closed

chore: rewrite go generator tests #808

wants to merge 11 commits into from

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Jul 8, 2022 •
edited
Loading

Description
This PR adapts the generator tests for Go.

@jonaslagoni jonaslagoni changed the base branch from master to next July 8, 2022 22:04
@jonaslagoni jonaslagoni marked this pull request as ready for review July 17, 2022 13:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonaslagoni jonaslagoni requested a review from smoya July 17, 2022 13:18
@jonaslagoni jonaslagoni mentioned this pull request Jul 17, 2022
Merged
7 tasks
@smoya
Copy link
Member

smoya commented Jul 18, 2022

Is this ready for review @jonaslagoni ? A little bit of more context is needed 🙏

@jonaslagoni
Copy link
Member Author

Is this ready for review @jonaslagoni ? A little bit of more context is needed 🙏

It is yes. Its one part of a larger rewrite, which is why the tests are failing.

So review it based on the snapshot changes and code changes, the best you can if anything jumps out 🙂

This was referenced Jul 21, 2022
Merged
Merged
@jonaslagoni
Copy link
Member Author

Accidentally merged by #806, but I dont want to take the time to revert the commits. @smoya if you see anything out of the ordinary, I can, but otherwise I leave it as is 🙂

@smoya
Copy link
Member

smoya commented Jul 25, 2022 •
edited
Loading

@jonaslagoni make sure we mention Go v1.18 is a requirement from now on (as it introduces generics, and the any type. Otherwise, 👍 !

@jonaslagoni
Copy link
Member Author

@jonaslagoni make sure we mention Go v1.18 is a requirement from now on (as it introduces generics, and the any type. Otherwise, 👍 !

Will do 👍

@jonaslagoni jonaslagoni deleted the feature/rewrite_go_generator_tests branch August 2, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@smoya smoya Awaiting requested review from smoya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonaslagoni @smoya