Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add missed methods to models #553

Merged

Conversation

magicmatatjahu
Copy link
Member

Description

  • add missed methods to models: AsyncAPI, Server, Channel, Operation, Message, mainly servers(), channels(), operations(), messages()
  • add unit tests

Related issue(s)
Part of #481
Part of #482

@sonarcloud
Copy link

sonarcloud bot commented May 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Comment on lines +76 to +78
schemas(): SchemasInterface {
return new Schemas([]);
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Atm we don't have implemented traverse function, so now function returns empty collections, it should be implemented and tested in next PRs.

@magicmatatjahu
Copy link
Member Author

@jonaslagoni Thanks!

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 6743a89 into asyncapi:next-major May 19, 2022
@magicmatatjahu magicmatatjahu deleted the next/extend-asyncapi-model branch May 19, 2022 09:23
magicmatatjahu added a commit to magicmatatjahu/parser-js that referenced this pull request Oct 3, 2022
derberg pushed a commit that referenced this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants