Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rebase with next-major branch #633

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Sep 30, 2022

Description

Rebase (or merge 😅) with next-major branch to enable contributions with API for new major spec.

I'm wondering if my approach in this PR is good, or should we remove the next-major-spec and create it based on next-major, or differently? Any suggestions on how to do it right?

In next PR I will add all needed code for models for next spec to start contributions.

cc @smoya @jonaslagoni @fmvilas @derberg

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@smoya
Copy link
Member

smoya commented Sep 30, 2022

I'm wondering if my approach in this PR is good, or should we remove the next-major-spec and create it based on next-major, or differently? Any suggestions on how to do it right?

I think the simplest solution is to reset the next-major-spec branch to next-major HEAD so both branches are identical. From there will diverge.

@magicmatatjahu
Copy link
Member Author

@smoya

I think the simplest solution is to reset the next-major-spec branch to next-major HEAD so both branches are identical. From there will diverge.

But after merging next-major to the master we will have still commits from next-major in the next-major-spec, so I'm afraid about bigger problems with rebase than with given PR. Any thoughts?

@smoya
Copy link
Member

smoya commented Sep 30, 2022

@smoya

I think the simplest solution is to reset the next-major-spec branch to next-major HEAD so both branches are identical. From there will diverge.

But after merging next-major to the master we will have still commits from next-major in the next-major-spec, so I'm afraid about bigger problems with rebase than with given PR. Any thoughts?

Totally the opposite, you won't have any conflict until the commit today HEAD of next-major points to. After that commit, you could have conflicts but you can't avoid that in any way.

@magicmatatjahu
Copy link
Member Author

Close in favour of #637

@magicmatatjahu magicmatatjahu deleted the rebase-with-next-major branch October 3, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants