Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update v3 models #708

Merged
merged 7 commits into from
Apr 12, 2023
Merged

chore: update v3 models #708

merged 7 commits into from
Apr 12, 2023

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Feb 1, 2023 •
edited
Loading

Description

Update v3 models:

Related issue(s)
See also asyncapi/spec#847

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Feb 1, 2023
@magicmatatjahu magicmatatjahu mentioned this pull request Feb 2, 2023
Merged
@jonaslagoni
Copy link
Member

@magicmatatjahu want this reviewed now, or later?

This was referenced Feb 8, 2023
Merged
Merged
@magicmatatjahu
Copy link
Member Author

@jonaslagoni Still spec PRs related to changes are not closed, so we can wait for it, but thanks!

@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu magicmatatjahu mentioned this pull request Apr 2, 2023
Closed
6 tasks
@magicmatatjahu
Copy link
Member Author

@jonaslagoni @smoya We can merge that PR. It contains about 90% needed changes for v3 models (based on v3 spec). Then we can add the missing stuff with rules.

This was referenced Apr 2, 2023
Closed
Closed
smoya
smoya approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@smoya smoya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

Read #585 (comment)

@smoya
Copy link
Member

smoya commented Apr 10, 2023

@fmvilas @jonaslagoni can you please review? I did, but I'm still not owner

smoya
smoya requested changes Apr 12, 2023
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#585 (comment)

fmvilas
fmvilas approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@smoya
Copy link
Member

smoya commented Apr 12, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 58b8b85 into asyncapi:next-major-spec Apr 12, 2023
@magicmatatjahu magicmatatjahu deleted the next-spec/new-objects branch April 12, 2023 14:26
@GreenRover GreenRover mentioned this pull request Apr 13, 2023
Merged
@jonaslagoni jonaslagoni mentioned this pull request Apr 26, 2023
Closed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.0-next-major-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoya smoya smoya requested changes

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@fmvilas fmvilas fmvilas approved these changes

@derberg derberg Awaiting requested review from derberg

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request ready-to-merge released on @next-major-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@magicmatatjahu @jonaslagoni @smoya @asyncapi-bot @fmvilas