feat: allow servers and channels to be defined as components

[smoya]

Note that this PR is targeting asyncapi:2022-01-release branch, so merging it won't release a new version.

Description
This PR is part of asyncapi/spec#660.
It allows both servers and channels to be defined as (and referenced from) components, meaning the following will be now valid:

servers:
  production:
    $ref: '#/components/servers/myserver'
channels:
  some/events:
    $ref: '#/components/channels/myChannel'
components:
  servers:
    myserver:
      url: "http://localhost:5000/ws"
      protocol: ws
  channels:
    myChannel:
      description: "mychannel"

You can see the diff between this new schema 2.3.0 vs the previous 2.2.0 here: https://www.diffnow.com/report/l7ib3

Alternative, attached here:

2c2
<   "title": "AsyncAPI 2.2.0 schema.",
---
>   "title": "AsyncAPI 2.3.0 schema.",
20c20
<         "2.2.0"
---
>         "2.3.0"
33,36c33
<       "type": "object",
<       "additionalProperties": {
<         "$ref": "#/definitions/server"
<       }
---
>       "$ref": "#/definitions/servers"
59a57
>       
165,168c163,166
<       "required": [
<         "url",
<         "protocol"
<       ],
---
>       "anyOf" : [
>         { "required" : ["url", "protocol"] },
>         { "required" : ["$ref"] }
>       ],    
175a174,176
>         "$ref": {
>           "$ref": "#/definitions/ReferenceObject"
>         },
202a204,209
>     "servers": {
>       "type": "object",
>       "additionalProperties": {
>         "$ref": "#/definitions/server"
>       }
>     },
262a270,275
>         },
>         "servers": {
>           "$ref": "#/definitions/servers"
>         },
>         "channels": {
>           "$ref": "#/definitions/channels"

Related issue(s)
asyncapi/spec#660

[magicmatatjahu]

@smoya You should wait for merge of it #139 and then switch PR's destination to the release-branch :) Changes are LGTM :)

[smoya]

then switch PR's destination to the release-branch

The destination branch is already there (it was already created) and this PR is targeting to be merged into it. If there are no other changes to introduce in 2.3.0 that are ready to merge on this repo, I think we can proceed with merging this one.

[magicmatatjahu]

hah, I got confused, sorry 😅

[magicmatatjahu]

LGTM

[derberg]

looks good but we need to wait for #139 and then you will need to solve some conflicts

[smoya]

looks good but we need to wait for #139 and then you will need to solve some conflicts

@derberg Would you mind approving this PR anyway? i won't mark it as ready to be merged until #139 is merged.

[derberg]

my approval won't make much sense as you will anyway have conflicts, which means additional commits that will cause a dismiss of my approval 😄

[smoya]

my approval won't make much sense as you will anyway have conflicts, which means additional commits that will cause a dismiss of my approval 😄

But it means a lot to my ❤️ , @derberg. Kidding, yeah you are right. Let's wait for those conflicts to come and get resolved!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[smoya]

This branch is now up-to-date with 2022-01-release and all conflicts have been solved. cc @derberg

[derberg]

/dnm

[derberg]

asyncapi/spec#665 merged, so merging this one too

/rtm

[asyncapi-bot]

🎉 This PR is included in version 2.13.0-2022-01-release.3 🎉

The release is available on:

• npm package (@2022-01-release dist-tag)
• GitHub release

Your semantic-release bot 📦🚀