Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add script to add new version #181

Closed
wants to merge 12 commits into from

Conversation

jonaslagoni
Copy link
Member

Description
As discussed in #128 this PR adds a new script to make it more maintainable instead of one long shell script.

@jonaslagoni
Copy link
Member Author

I have no idea what the sonar rules are called, so I don't know how to disable them.

I did add a simple input check to see if it matches semver version, so there should be no unsafe OS commands possible.

For the codesmell, cant really do anything about it, as this is the regex suggested on the semver site.

@derberg
Copy link
Member

derberg commented Mar 17, 2022

@jonaslagoni sonar is complaining about script that runs only in CI, so just ignore it entirely for sonar

I have other problem with this PR, you make many changes that come from the fact that you create a PR not from next-major but from master, and therefore there are these workflow changes that should not be there. You know what I mean?

@jonaslagoni
Copy link
Member Author

I have other problem with this PR, you make many changes that come from the fact that you create a PR not from next-major but from master, and therefore there are these workflow changes that should not be there. You know what I mean?

Pr is up #187

@jonaslagoni jonaslagoni changed the base branch from next-major to master March 23, 2022 13:38
@jonaslagoni jonaslagoni changed the base branch from master to next-major March 23, 2022 13:38
@jonaslagoni
Copy link
Member Author

@jonaslagoni sonar is complaining about script that runs only in CI, so just ignore it entirely for sonar

Is this something we have to do from the platform itself or? 🤔

@derberg
Copy link
Member

derberg commented Mar 23, 2022

@jonaslagoni no, we always tend to do it with config files in repo, like before...or I didn't get something

btw, you need to update PR with latest next-major

@jonaslagoni
Copy link
Member Author

btw, you need to update PR with latest next-major

I have.

@jonaslagoni no, we always tend to do it with config files in repo, like before...or I didn't get something

Problem is, as I think it was last time. I dont have access to the configuration "keys" that is needed to disable the check 🤔

@derberg
Copy link
Member

derberg commented Mar 23, 2022

sorry, I thought you are aware of something like https://github.com/asyncapi/glee/blob/master/.sonarcloud.properties so you can exclude entire script from all the rules

oko, so now we have a script, but how is it triggered?

@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell B 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni
Copy link
Member Author

Gonna redo this once #184 is merged.

@jonaslagoni jonaslagoni marked this pull request as draft April 11, 2022 12:14
@asyncapi-bot asyncapi-bot deleted the branch asyncapi:next-major May 16, 2022 16:55
@jonaslagoni
Copy link
Member Author

Damn, when targeted branches are removed, remaining PRs are closed as well with no way to retarget them...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants