Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tags field to Server Object #232

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

smoya
Copy link
Member

@smoya smoya commented Jun 17, 2022

Description

This PR adds support for defining Tags at Server Object. They can be used for providing metadata, including the environment such as production, development, etc.

Related issue(s)
asyncapi/spec#654

@smoya smoya changed the title Feat/server tags feat: add tags field to Server Object Jun 17, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@char0n char0n mentioned this pull request Sep 20, 2022
61 tasks
@smoya
Copy link
Member Author

smoya commented Sep 20, 2022

@fmvilas @dalelane @derberg a last review so we can include this into 2.5 finally?

@fmvilas
Copy link
Member

fmvilas commented Sep 20, 2022

I think it's only lacking approval from Lukasz.

@smoya
Copy link
Member Author

smoya commented Sep 22, 2022

@derberg would you mind doing a review of this so we can include it in 2.5? Thanks!

@char0n
Copy link
Collaborator

char0n commented Sep 22, 2022

Looks good here. Ready to be incorporated into 2.5 release. Thanks @smoya. Going for a merge.

@char0n
Copy link
Collaborator

char0n commented Sep 22, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit c74a1bf into asyncapi:next-spec Sep 22, 2022
@smoya smoya deleted the feat/serverTags branch September 22, 2022 08:57
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.15.0-next-spec.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.2.0-next-spec.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants