-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add schema listing all Schema-Store JSON Schema docs #237
feat: add schema listing all Schema-Store JSON Schema docs #237
Conversation
f02907b
to
302371a
Compare
After a private conversation with @magicmatatjahu, he suggested me a simplest version of the schema: {
"$id": "http://asyncapi.com/schema-store/all.schema-store.json",
"$schema": "http://json-schema.org/draft-07/schema",
"title": "JSON Schema documents for all AsyncAPI spec versions",
"description": "All AsyncAPI JSON Schema documents listed in one file. Needed for serving all documents through schemastore.org",
"type": "object",
"oneOf": [
{
"$ref": "http://asyncapi.com/schema-store/1.0.0.json"
},
{
"$ref": "http://asyncapi.com/schema-store/1.1.0.json"
},
{
"$ref": "http://asyncapi.com/schema-store/1.2.0.json"
},
{
"$ref": "http://asyncapi.com/schema-store/2.0.0-rc1.json"
},
{
"$ref": "http://asyncapi.com/schema-store/2.0.0-rc2.json"
},
{
"$ref": "http://asyncapi.com/schema-store/2.0.0.json"
},
{
"$ref": "http://asyncapi.com/schema-store/2.1.0.json"
},
{
"$ref": "http://asyncapi.com/schema-store/2.2.0.json"
},
{
"$ref": "http://asyncapi.com/schema-store/2.3.0.json"
},
{
"$ref": "http://asyncapi.com/schema-store/2.4.0.json"
}
]
} However, as he pointed out, schemas like http://asyncapi.com/definitions/1.1.0.json have the following enum on "asyncapi": {
"type": "string",
"enum": [
"1.0.0",
"1.1.0"
],
"description": "The AsyncAPI specification version of this document."
}, So it definitely won't work. We should keep the solution I'm adding in this PR. |
882a839
to
b86b976
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dalelane whenever you have a chance, I need your +1 to merge this and move forward with the PR I should open on JSON Schema Store. Thank you! |
/rtm |
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Partially fixes #236, pending a PR on JSON Schema-Store repository.
This PR adds a new schema file that lists all JSON Schema files for all AsyncAPI spec versions. This is required for Schema-Store IDE plugins to support all versions.
Related issue(s)
#236