-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added schema for 2.2.0 based on 2.1.0 and added anypointmq protocol #90
feat: added schema for 2.2.0 based on 2.1.0 and added anypointmq protocol #90
Conversation
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7. - [Release notes](https://github.com/jbgutierrez/path-parse/releases) - [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7) --- updated-dependencies: - dependency-name: path-parse dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
Co-authored-by: asyncapi-bot <info@asyncapi.io> Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
@derberg : i've commited the 2.2.0 schema, but for whatever reason 6 more files (such as .github/workflows/automerge-orphans.yml) are listed in this PR: i did not touch those. What should i do? |
hey, I think you created a branch in your fork from latest master and not the release branch and in this PR, instead of just changes in the schema, you introduce other changes that were in master but not in release branch. Can you revert that? so changes here are only about the json schema? |
you might be right @derberg , how embarrassing. I've cleaned this up now. |
@GeraldLoeffler no worries. All looks good from my side if it comes to the schema, I checked with external diff checker. You need to just add new schema here https://github.com/asyncapi/spec-json-schemas/blob/2021-09-release/index.js, this is why tests are failing |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🚀
@fmvilas anything from your side?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, ship it!
🎉 This PR is included in version 2.9.0-2021-09-release.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.9.0-2021-09-release.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
2.1.0
to2.2.0
anypointmq
protocol as per [RFC] Create Anypoint MQ protocol and bindings spec#514Related issue(s)