Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added schema for 2.2.0 based on 2.1.0 and added anypointmq protocol #90

Merged
merged 8 commits into from
Sep 16, 2021

Conversation

GeraldLoeffler
Copy link
Collaborator

Description

Related issue(s)

asyncapi-bot and others added 6 commits August 10, 2021 14:16
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
Co-authored-by: asyncapi-bot <info@asyncapi.io>
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
@GeraldLoeffler GeraldLoeffler changed the title added schema for 2.2.0 based on 2.1.0 and added anypointmq protocol feat: added schema for 2.2.0 based on 2.1.0 and added anypointmq protocol Sep 2, 2021
@GeraldLoeffler
Copy link
Collaborator Author

@derberg : i've commited the 2.2.0 schema, but for whatever reason 6 more files (such as .github/workflows/automerge-orphans.yml) are listed in this PR: i did not touch those. What should i do?

@derberg
Copy link
Member

derberg commented Sep 3, 2021

hey, I think you created a branch in your fork from latest master and not the release branch and in this PR, instead of just changes in the schema, you introduce other changes that were in master but not in release branch. Can you revert that? so changes here are only about the json schema?

@GeraldLoeffler
Copy link
Collaborator Author

you might be right @derberg , how embarrassing. I've cleaned this up now.

@derberg
Copy link
Member

derberg commented Sep 15, 2021

@GeraldLoeffler no worries. All looks good from my side if it comes to the schema, I checked with external diff checker. You need to just add new schema here https://github.com/asyncapi/spec-json-schemas/blob/2021-09-release/index.js, this is why tests are failing

Screenshot 2021-09-15 at 16 36 40

Screenshot 2021-09-15 at 16 36 59

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@fmvilas anything from your side?

Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, ship it!

@derberg derberg merged commit cde9048 into asyncapi:2021-09-release Sep 16, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.9.0-2021-09-release.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.9.0-2021-09-release.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants