Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adapting release process to new definition setup #659

Merged
merged 9 commits into from
Jun 17, 2022
Merged

docs: adapting release process to new definition setup #659

merged 9 commits into from
Jun 17, 2022

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Nov 25, 2021 •
edited
Loading

This PR adapts the release process documentation to follow the new definition setup in the spec-json-schemas repository.

Related PR in spec-json-schemas: asyncapi/spec-json-schemas#128

@jonaslagoni jonaslagoni mentioned this pull request Nov 25, 2021
Merged
@jonaslagoni jonaslagoni marked this pull request as ready for review November 25, 2021 18:10
@jonaslagoni jonaslagoni marked this pull request as draft November 29, 2021 07:40
@derberg
Copy link
Member

derberg commented Dec 1, 2021

@jonaslagoni both PRs are draft, is it something you want me to look into now or wait?

@jonaslagoni jonaslagoni removed the request for review from derberg December 1, 2021 14:04
@jonaslagoni
Copy link
Member Author

@jonaslagoni both PRs are draft, is it something you want me to look into now or wait?

Forgot to take you off as a reviewer sorry!

We need to figure out asyncapi/spec-json-schemas#128 (comment) before it can be finalized.

@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonaslagoni jonaslagoni mentioned this pull request Feb 16, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni jonaslagoni changed the base branch from master to next-major March 14, 2022 12:08
@jonaslagoni jonaslagoni marked this pull request as ready for review March 14, 2022 12:13
@jonaslagoni
Copy link
Member Author

I can't figure out if the link should point to https://github.com/asyncapi/spec-json-schemas/tree/next-major instead of master? 🧐

fmvilas
fmvilas previously approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fmvilas
Copy link
Member

fmvilas commented Mar 14, 2022

I'd leave it pointing to master because we not only create new versions on majors.

@smoya
Copy link
Member

smoya commented Mar 18, 2022

As the new changes in spec-json-schemas (splitting out definitions) will be used for the 2.4.0, this branch could point now to the release branch 2022-04-release.

@derberg
Copy link
Member

derberg commented Mar 21, 2022 •
edited
Loading

Hey folks, afaik split JSON Schema definitions are not released and are not in master, so should not be used in 2.4 and should not be mentioned in the release process document for now, not on master.

@smoya
Copy link
Member

smoya commented Mar 21, 2022

Hey folks, afaik split JSON Schema definitions are not released and are not in master, so should not be used in 2.4 and should not be mentioned in the release process document for now, not on master.

They should totally be merged in master ASAP I would say. cc @jonaslagoni Why would we wait for releasing this?

@jonaslagoni
Copy link
Member Author

Related PR asyncapi/spec-json-schemas#184

@derberg
Copy link
Member

derberg commented Mar 23, 2022

did you have some conversation somewhere about the definitions split that I'm not aware of? On PR that introduced it, I remember the goal was 3.0 spec release. This is why it was not released as asyncapi/spec@3.0.0 but was exposed as a release candidate. And now all suddenly we need it ASAP for 2.4 🤷🏼

@jonaslagoni
Copy link
Member Author

jonaslagoni commented Mar 23, 2022 •
edited
Loading

did you have some conversation somewhere about the definitions split that I'm not aware of? On PR that introduced it, I remember the goal was 3.0 spec release. This is why it was not released as asyncapi/spec@3.0.0 but was exposed as a release candidate. And now all suddenly we need it ASAP for 2.4 🤷🏼

it was, however, the changes introduced for spec 3.0 is not a breaking change in itself, just another spec version 🙂 And as I understood @smoya wanted the split definitions for spec 2.4 as it makes it much easier to contribute. That is the reason we are pushing for just releasing the feature cause it does not really make sense to delay it as no other changes are breaking.

@smoya
Copy link
Member

smoya commented Mar 23, 2022 •
edited
Loading

did you have some conversation somewhere about the definitions split that I'm not aware of? On PR that introduced it, I remember the goal was 3.0 spec release. This is why it was not released as asyncapi/spec@3.0.0 but was exposed as a release candidate. And now all suddenly we need it ASAP for 2.4 🤷🏼

Some of us realized during last Spec 3.0 meeting that this could be released earlier without having to wait since it has nothing to do with Spec 3.0. You can watch the video in https://youtu.be/GRfVx5bd9ag.
Of course, no decision was taken in the meeting, but I guess there is not a lot of decision to take i guess.

As I raised here, why would we wait for releasing this?

dalelane
dalelane previously approved these changes Mar 23, 2022
View reviewed changes
@derberg
Copy link
Member

derberg commented Mar 24, 2022

@smoya no need to wait, I was only surprised by a sudden change in approach and just wanted to understand where it is coming from 😄 I'm all with releasing it now. I'm actually always supportive of major releases in our libraries whenever there is a need, without being afraid of introducing breaking changes often, as long as it is needed from DX point of view.

derberg
derberg previously approved these changes Mar 24, 2022
View reviewed changes
smoya
smoya previously approved these changes Mar 24, 2022
View reviewed changes
@jonaslagoni jonaslagoni changed the base branch from next-major-spec to master May 17, 2022 09:15
@jonaslagoni jonaslagoni dismissed stale reviews from smoya, derberg, dalelane, and fmvilas May 17, 2022 09:15

The base branch was changed.

@jonaslagoni
Copy link
Member Author

jonaslagoni commented May 17, 2022 •
edited
Loading

Alright, I have updated the PR, retarget it to master, and added links to the 3.0.0 schema changes as an example.

Is ready to be reviewed.

fmvilas
fmvilas requested changes May 17, 2022
View reviewed changes
RELEASE_PROCESS.md Outdated Show resolved Hide resolved
@jonaslagoni @fmvilas
Update RELEASE_PROCESS.md
4973d4f 
Co-authored-by: Fran Méndez <fmvilas@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

fmvilas
fmvilas approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fmvilas
Copy link
Member

fmvilas commented Jun 17, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 03a7a95 into asyncapi:master Jun 17, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-major-spec.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@fmvilas
Copy link
Member

fmvilas commented Sep 22, 2022

Forget about the last comment saying it was released in version 2.5.0-next-major-spec.1. I made a mistake and it created this version but it should actually be 3.0.0-next-major-spec.1. There's a notice in the release. Apologies for the noise.

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-spec.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Jan 31, 2023

Recent comments about the release from the bot were added by mistake. More details in #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalelane dalelane dalelane approved these changes

@fmvilas fmvilas fmvilas approved these changes

@smoya smoya smoya left review comments

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jonaslagoni @derberg @fmvilas @smoya @asyncapi-bot @dalelane