feat: add Solace bindings to the list of supported bindings in the spec. #666
Conversation
|
Looks good to me, excited to have Solace join the bindings. |
There was a problem hiding this comment.
@MichaelDavisSolace please also update the sections I shared in below screen shots
(1)
(2)
@fmvilas IMHO we can move it to Draft stage as PR for schema is also there. There are some fixes needed for this PR but this is why it is stage 2 not 3
|
Kudos, SonarCloud Quality Gate passed!
|
|
Yeah, I think this can be marked as Draft already. @MichaelDavisSolace I think the next step would be to get the JSON Schema version into the JS Parser and we'd be done. In the parser, you can point to your branch temporarily so it can be tested. |
Okay, will do. |
|
I see Dale Lane is the one who got the 2.3.0 schema into the spec-json-schemas repo. Does that mean that he'll be the one to update parser-js? |
derberg
added
🏁 Accepted (RFC 3)
There was a problem hiding this comment.
@fmvilas I approved this one and promoted to accepted
Imho asyncapi/spec-json-schemas#143 is enough for now and agree with one of the comments Michael did in Slack that in case of this feature, where there is just small change in the schema, it doesn't make sense to open up a PR before asyncapi/spec-json-schemas#143 is actually merged and the release candidate is ready.
So @fmvilas once you approve this one and release it, then release PR for JSON Schema, please just open a bump PR in the Parser to the release branch...or just merge together with asyncapi/parser-js#430 and @smoya will bump it
|
/rtm |
|
🎉 This PR is included in version 2.3.0-2022-01-release.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Solace Binding Protocal has been included with release 2.3.0 of AsyncAPI, with: - asyncapi/spec@88abbe0 - asyncapi/spec#666 Thus, specification example should indicate at least this version. --- Noticed by working on Solace Protocol support on https://bump.sh
Solace Binding Protocol has been included with release 2.3.0 of AsyncAPI, with: - asyncapi/spec@88abbe0 - asyncapi/spec#666 Thus, specification example should indicate at least this version. --- Noticed by working on Solace Protocol support on https://bump.sh
Solace Binding Protocol has been included with release 2.3.0 of AsyncAPI, with: - asyncapi/spec@88abbe0 - asyncapi/spec#666 Thus, specification example should indicate at least this version. While here, let's favor last released version 2.4.0, as suggested by @fmvilas --- Noticed by working on Solace Protocol support on https://bump.sh/asyncapi
Solace Binding Protocol has been included with release 2.3.0 of AsyncAPI, with: - asyncapi/spec@88abbe0 - asyncapi/spec#666 Thus, specification example should indicate at least this version. While here, let's favor last released version 2.4.0, as suggested by @fmvilas --- Noticed by working on Solace Protocol support on https://bump.sh/asyncapi
title: "Add Solace bindings to the list of supported bindings in the spec."
This is a request to add the Solace bindings to the lists of bindings in the spec.
The PR for the json schema repo corresponding to this PR is here: asyncapi/spec-json-schemas#136