Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix URN examples #718

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Conversation

mike-schenk
Copy link
Contributor

@mike-schenk mike-schenk commented Feb 9, 2022


title: "Use valid URIs or URNs in Identifier examples"

Changes invalid URN examples to either valid URIs or to valid URNs according to the linked RFC 8141 and its associated IANA URN namespaces registry.

Reverse DNS names do not form valid URNs. The registry of defined URN namespace identifiers is quite limited. Because of that, it seems unlikely that a valid URN will actually be useful in the context of an AsyncAPI document, but to make the minimal change in the spec document, I used the example namespace identifier.

Instead of a URN, a URI with the registered tag scheme seems to apply better. Since the semantics of the tag URI scheme appear to match the desired intent of a universally-unique and long-lived identifier.

This is an editorial change, but I apparently can't set that label myself.


Related issue(s):


…ccording to the linked RFC 8141 and its associated IANA URN namespaces registry.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 10, 2022
@derberg
Copy link
Member

derberg commented Jun 13, 2022

@mike-schenk hi, I'm really sorry for getting so late here. Can you solve merge conflicts please 🙏🏼

@fmvilas @dalelane anything from your side?

fmvilas
fmvilas previously approved these changes Jun 13, 2022
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Other than the merge conflicts, of course 😄

@github-actions github-actions bot removed the stale label Jun 14, 2022
dalelane
dalelane previously approved these changes Jun 19, 2022
Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mike-schenk - would you like some help with the merge conflicts?

@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mike-schenk
Copy link
Contributor Author

Merge conflicts resolved.

Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@derberg
Copy link
Member

derberg commented Jun 21, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 8612838 into asyncapi:master Jun 21, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-major-spec.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@fmvilas
Copy link
Member

fmvilas commented Sep 22, 2022

Forget about the last comment saying it was released in version 2.5.0-next-major-spec.1. I made a mistake and it created this version but it should actually be 3.0.0-next-major-spec.1. There's a notice in the release. Apologies for the noise.

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-spec.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Jan 31, 2023

Recent comments about the release from the bot were added by mistake. More details in #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants