Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(release): update list of tools and maintainers to notify when releasing #770

Merged
merged 8 commits into from
Jun 10, 2022
Merged

docs(release): update list of tools and maintainers to notify when releasing #770

merged 8 commits into from
Jun 10, 2022

Conversation

smoya
Copy link
Member

@smoya smoya commented Apr 26, 2022

This PR updates RELEASE_PROCESS.md file. In particular, the list of repositories whose owners should be notified when prereleasing.

@smoya smoya mentioned this pull request Apr 26, 2022
Closed
55 tasks
fmvilas
fmvilas previously approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked if that's the whole list of tools but the one you're proposing looks good to me 👍

dalelane
dalelane previously approved these changes Apr 29, 2022
View reviewed changes
@smoya
Copy link
Member Author

smoya commented May 2, 2022

@derberg whenever you have a chance, could you review this? No rush 👍

derberg
derberg reviewed May 9, 2022
View reviewed changes
RELEASE_PROCESS.md Outdated Show resolved Hide resolved
@smoya smoya dismissed stale reviews from dalelane and fmvilas via d7dc58f May 9, 2022 16:59
@smoya smoya requested review from derberg, dalelane and fmvilas May 9, 2022 17:01
derberg
derberg previously approved these changes May 9, 2022
View reviewed changes
@smoya
Copy link
Member Author

smoya commented May 9, 2022

@dalelane @fmvilas since your last review, I provided an alternative to GH Code Search to query for code dependants on the spec and parsers. d7dc58f

Would you mind checking and, if all good, approving again? Thanks! 🙏

derberg
derberg previously approved these changes May 9, 2022
View reviewed changes
dalelane
dalelane previously approved these changes May 9, 2022
View reviewed changes
Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - that's a neat approach 👍

RELEASE_PROCESS.md
- [Studio](https://github.com/asyncapi/studio)
- [TS NATS Template](https://github.com/asyncapi/ts-nats-template)

You can use Github Code Search to find the [list of repositories depending on parser-js or the specs](https://cs.github.com/?scopeName=All+repos&scope=&q=org%3Aasyncapi+%28path%3Apackage.json+OR+go.mod%29+%22%40asyncapi%2Fparser%22+OR+%22%40asyncapi%2Fspecs%22+OR+%22github.com%2Fasyncapi%2Fspec-json-schemas%22+OR+%22github.com%2Fasyncapi%2Fparser-go%22#).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still on the waiting list for code search so I can't try this, but it's a neat idea

@smoya smoya dismissed stale reviews from dalelane and derberg via be78198 May 10, 2022 18:58
@smoya smoya requested a review from dalelane May 11, 2022 08:21
@smoya
Copy link
Member Author

smoya commented Jun 10, 2022

/rtm

@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@asyncapi-bot asyncapi-bot merged commit 84576c8 into asyncapi:master Jun 10, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-major-spec.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@fmvilas
Copy link
Member

fmvilas commented Sep 22, 2022

Forget about the last comment saying it was released in version 2.5.0-next-major-spec.1. I made a mistake and it created this version but it should actually be 3.0.0-next-major-spec.1. There's a notice in the release. Apologies for the noise.

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-spec.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Jan 31, 2023

Recent comments about the release from the bot were added by mistake. More details in #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalelane dalelane dalelane approved these changes

@derberg derberg derberg approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smoya @asyncapi-bot @fmvilas @derberg @dalelane