Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify how URL form is resolved #782

Merged
merged 3 commits into from
Sep 7, 2022
Merged

docs: clarify how URL form is resolved #782

merged 3 commits into from
Sep 7, 2022

Conversation

char0n
Copy link
Collaborator

@char0n char0n commented May 4, 2022 •
edited
Loading

Refs #674

Along with the clarification of URL resolution, I've made the sentence that describes the fact that the value is URL consistent within the spec. This makes it possible to identify all URL forms within the specification using native browser search capability (CTRL+F).

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@char0n char0n mentioned this pull request May 4, 2022
Closed
dalelane
dalelane previously approved these changes May 5, 2022
View reviewed changes
@char0n char0n mentioned this pull request May 6, 2022
Open
derberg
derberg reviewed May 10, 2022
View reviewed changes
spec/asyncapi.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@char0n
Copy link
Collaborator Author

char0n commented Jul 5, 2022

PR has been redo into absolute URLs only support.

@char0n char0n requested review from derberg and dalelane and removed request for derberg and dalelane September 6, 2022 11:20
@char0n
Copy link
Collaborator Author

char0n commented Sep 6, 2022

@fmvilas @derberg @dalelane can you please have a final look at this? Thanks!

fmvilas
fmvilas approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Makes sense

@derberg derberg changed the title docs(spec): clarify how URL form is resolved docs: clarify how URL form is resolved Sep 7, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

derberg
derberg approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This editorial change definitely makes sense. Our JSON Schema is also aligned. We have uri format everywhere it is needed.

@derberg
Copy link
Member

derberg commented Sep 7, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit fc324ef into asyncapi:master Sep 7, 2022
This was referenced Sep 13, 2022
Closed
Closed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-major-spec.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@fmvilas
Copy link
Member

fmvilas commented Sep 22, 2022

Forget about the last comment saying it was released in version 2.5.0-next-major-spec.1. I made a mistake and it created this version but it should actually be 3.0.0-next-major-spec.1. There's a notice in the release. Apologies for the noise.

@derberg derberg mentioned this pull request Sep 28, 2022
Merged
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.5.0-next-spec.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Jan 31, 2023

Recent comments about the release from the bot were added by mistake. More details in #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

@dalelane dalelane dalelane approved these changes

@derberg derberg derberg approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major-spec released on @next-spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@char0n @derberg @asyncapi-bot @fmvilas @dalelane