ci: updating spec urls to match new Information Architecture in website #801
Conversation
quetzalliwrites
requested review from
fmvilas,
derberg,
dalelane and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
@fmvilas that work is in PR 601 which is mentioned here 😜 |
Let's say new release is It is performed as "addition", not "override", it is added on top of the list @alequetzalli so this PR is good, but you need more updates in PR on website. this 👇🏼 must be 👇🏼 so in future releases, after 2.5 it looks like👇🏼 I hope this makes sense 😅 |
|
Oh sorry, I saw the response from Ale and forgot to reply 😓 Yeah, I'm fine with it 👍 |
|
We need also update |
@magicmatatjahu Why do I need to update the toc file in this? The toc changes you are working on have nothing to do with this PR. TOC updates are not IA related. |
Great feedback, thank you @derberg! I will reach out if I get confused |
|
@alequetzalli because that script removes TOC from spec files, so you need also update that script as well
and it and it we need to remove TOC, but from markdown. Please check these files and you will see that there are also https://github.com/asyncapi/spec/blob/master/.github/scripts/remove-toc.js#L12 |
|
@magicmatatjahu Ah! I think I follow you now... Thanks for the detailed specifics and I'll let you know if I need more help |
|
@magicmatatjahu good catch! |
|
@derberg thanks! I have a question, because @derberg you added a comment about redirects (here #801 (comment)) and I wonder if we need to change the script to produce 2 redirects for each spec, for |
|
@magicmatatjahu yeah, I suggested it this way intentionally. Keep old, but for new, not. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@magicmatatjahu Let me know if I followed all your instructions correctly! This PR is ready for review again 😸 cc @derberg |
We'll have you merge them right @derberg? I assumed it made the most sense for you to be the maintainer to merge both when ready. |
|
@alequetzalli definitely! good assumption 😄 |
derberg
changed the title
|
/rtm |
* feat: merge with latest master * ci: updating spec urls to match new Information Architecture in website (#801) * docs: fix links in Markdown files (#769) Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com> Co-authored-by: Khuda Dad Nomani <32505158+KhudaDad414@users.noreply.github.com>
|
🎉 This PR is included in version 2.5.0-next-major-spec.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Forget about the last comment saying it was released in version 2.5.0-next-major-spec.1. I made a mistake and it created this version but it should actually be |
|
🎉 This PR is included in version 2.5.0-next-spec.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Recent comments about the release from the bot were added by mistake. More details in #899 |
title: "updating spec urls to match new Information Architecture changes via asyncapi/website#601"
301 updates due to GSoD IA changes
Related issue(s):
asyncapi/website#601