Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update some examples according to v3 #971

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

smoya
Copy link
Member

@smoya smoya commented Sep 17, 2023

This PR fixes one example I found was out of date.

As a side note, It would be nice if all examples within the spec (not the ones in examples dir) are tested by CI. For that, we would need to include full examples (with all the required fields, such as info, etc). #957 might be the issue to push for.

@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@smoya
Copy link
Member Author

smoya commented Sep 17, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit abfae49 into asyncapi:next-major-spec Sep 17, 2023
31 of 32 checks passed
@smoya smoya deleted the fix/example branch September 17, 2023 22:06
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major-spec.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants