-
-
Notifications
You must be signed in to change notification settings - Fork 13
feat: initial version #1
feat: initial version #1
Conversation
… installed by links.
…ent type for all the client methods.
Hey mate! Just a quick reminder that we're migrating the template structure. You should move everything that should or might be copied to the output folder to its own folder called "template". Also, .filters, .hooks, and .partials are now called filters, hooks, and partials respectively. And they should be placed outside the "template" folder, i.e. in the root folder of this repo, along with the package.json file, etc. See this PR as an example: asyncapi/nodejs-template#5 |
… the generated code. fix: Ensured the right client is used for the right channels. fix: The channelname is not realized based on paramters and converted to NATS channel.
I have added some integration tests which the template generates in order to test that both the test client and and client can talk to each other and gets the correct data. That finishes the initial version IMO, so this should be the last review unless other changes are requested. |
@jonaslagoni I think we can merge it as then improve afterwords. Just solve conflict and remove Remeber that |
@derberg good call, all done 👍 |
@jonaslagoni you did not remove |
Yea merged master into my PR. But I have removed them now. |
@fmvilas as per my comment
can you approve PR too? |
🎉 This PR is included in version 0.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@all-contributors please add @ColinSullivan1 review |
I've put up a pull request to add @ColinSullivan1! 🎉 |
@all-contributors please add @aricart review |
I've put up a pull request to add @aricart! 🎉 |
@all-contributors please add @aricart review |
I've put up a pull request to add @aricart! 🎉 |
Description
Here are some of the features I include in the template:
TODO
BeforeSendingData
andRecievedData
hooks for changing the messageThe security schemas have in this version no influence on what is generated. I don't have an actual use-case where this is necessary so this will not be prioritized.
TODO (maybe)
Waiting for asyncapi/generator#216 to decide whether to continue include the following:
Decide ifallOf
,anyOf
andoneOf
should be included in generating messages and schemas. If not, remove existing codeChanged to let quicktype generate the schemas.
allOf
messages are not supported.Add enum schema generationLetting quicktype handle this.
Issues it fixes