-
-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adding document for Adding messages page #2025
Conversation
✅ Deploy Preview for shimmering-choux-eb0798 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some suggestions. Please have a look and provide your thoughts/feedback on it.
@mhmohona
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments. I'm not fully aware of the GSoD issues and their context. I need @alequetzalli to provide a bit of guidance here first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another round of reviews :) Keep pushing! Specifically, I have concerns with having so many diagrams trying to explain things that may not need a diagram at all.
```mermaid | ||
flowchart TB | ||
|
||
subgraph Components Object | ||
Component_1 | ||
Component_2 | ||
Component_3 | ||
end | ||
|
||
subgraph API | ||
API_implementation --> Component_1:Uses | ||
API_implementation --> Component_2:Uses | ||
API_implementation --> Component_3:Uses | ||
|
||
style API_implementation fill:#47BCEE,stroke:#47BCEE; | ||
end | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused by this diagram. What exactly did you try to convey here? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to explain the reusing components section here. Do you think I should change it? In what way it would be better in your opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
Added Adding Messages page.
It is a part of GSoD'23 project.
Related issue(s):
fixes #1514