chore: add parameter section in migration #2293
Conversation
jonaslagoni
requested review from
quetzalliwrites,
asyncapi-bot-eve,
derberg,
mcturco,
akshatnema and
magicmatatjahu
as code owners
✅ Deploy Preview for shimmering-choux-eb0798 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks @alequetzalli 👍 |
|
/rtm |
|
lol slow your roll, @jonaslagoni, this PR needs 2 approvals to merge since I added a few commits, that automatically re-requests reviewers to approve PR again... you need @derberg (or another code owner) to hit approve again |
|
If anything is missing i.e. approves it wont do anything but let them know that I see it as being ready to be merged 🙂 So yea now it's up the codeowners to merge it 🙂 |
|
I'm actually going to merge any of these v3 PRs that I'm able to, I know these are ready to merge cause I approved them. lol duh 😂😂😂😂 But like you saw, I cannot merge the PRs I make commits to cause our repo has permissions set up as defined above. Breathe dude, these are all getting merged for the release and Lukasz and I are working together as needed to move them forward. |
Yo man! I got your notification at 3 AM at night 😄. So, I'll look into PR tomorrow. Sorry, it got missed off in previous notifications. |
|
oooh @akshatnema this is like SO ready to go, can you help him by approving? we don't really need another review, it's already approved by lukasz and I |
|
There are no rush here folks 😆 It happens when it happens, I am just using No need to freak out over it, I just do it so we are at least not waiting on me in any sense 😆 Which have happened in the past where an approval was given but nobody did the |
Yeah, I looked into the PR preview. I'm quite suspicious that the comparison that is created is not working well in the mobile view. I was touching repeatedly on the sections, but they haven't been highlighted. That's why, I'll look into the PR tomorrow, from my laptop. And will do some manual testing. |
|
oh interesting! thanks for helping catch issues @akshatnema, appreciate you! :) |
|
Hey @jonaslagoni, I'm not able to get any hover effect on this component. Why?
Also, in the following component, I'm not able to get hover activity at schema field.
The following fields are automatically colored, without hovering into them:
|
Back in the first PR I didnt really see what to compare, so I never added any effects there.
Fixed that one 👍
Because they are removed and no longer available 🙂 |
|
/rtm |
|
@alequetzalli Can you please re-approve this PR? Your preview review got dismissed. |
|
/rtm |
Description
This PR adds the missing parameter section that gives an overview of the new parameter object.
I also decided to remove the initial interactive comparison, as with the number of changes it simply became so cluttered that it was no longer possible to get anything meaningful out of it...
I also added a small section on the messageId that is now removed.