Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(blog): websocket part 3 about code generation #237

Merged
merged 19 commits into from
May 19, 2021

Conversation

derberg
Copy link
Member

@derberg derberg commented Apr 29, 2021

This article explains how to dining WebSocket API with multichannel, where every channel has just one message. It shows how code generation works. It tries to be honest with the reader and points out code generation difficulties/challenges.

@fmvilas I need your help with CSS, I'm too dumb for this:

  • I could not figure out where I need to make a change to get all images centered.
  • I also do not like that when I have 1-2-3 instruction, code samples intend is not going under text but the instruction number too, but could not figure out what CSS could change it
  • last but not least - I think that the navigation building is broken, even though I have different headings, there is no indentation visible

Happy to solve all those errors but need some direction.

Fixes #256

@netlify
Copy link

netlify bot commented Apr 29, 2021

Deploy preview for asyncapi-website processing.

Building with commit b42a90e

https://app.netlify.com/sites/asyncapi-website/deploys/60a391723515f8000863cc9b

@fmvilas
Copy link
Member

fmvilas commented May 9, 2021

I also do not like that when I have 1-2-3 instruction, code samples intend is not going under text but the instruction number too, but could not figure out what CSS could change it

I don't understand what's your concern. Can you point me to an example?

@fmvilas
Copy link
Member

fmvilas commented May 9, 2021

TOC fixed. Thanks for pointing it out!

@derberg
Copy link
Member Author

derberg commented May 10, 2021

@fmvilas

Screenshot 2021-05-10 at 13 34 54

code snippet is aligned with 1. while indent should make it aligned with Create

example from almighty internet that is full of unlimited inspiration resources 😄 some self-mocked example from Stripe docs
Screenshot 2021-05-10 at 13 38 07

@fmvilas
Copy link
Member

fmvilas commented May 10, 2021

I see. Can you open a different issue? Maybe @magicmatatjahu can have a look later.

@derberg
Copy link
Member Author

derberg commented May 10, 2021

@fmvilas issue opened #256

thanks for your help 🙏🏼

Technically all good, you can have a look at the content itself 😉

@magicmatatjahu
Copy link
Member

magicmatatjahu commented May 10, 2021

@derberg Please remove list-inside class from 45 and 46 lines in this file https://github.com/asyncapi/website/blob/master/pages/_app.js#L46 :)

And then you will have
image

@derberg
Copy link
Member Author

derberg commented May 11, 2021

@magicmatatjahu thank you, works

Screenshot 2021-05-11 at 11 28 34

@derberg derberg requested a review from fmvilas May 11, 2021 09:50
@derberg
Copy link
Member Author

derberg commented May 11, 2021

@fmvilas technically all is good, now just need review of content itself

pages/blog/websocket-part3.md Outdated Show resolved Hide resolved
pages/blog/websocket-part3.md Outdated Show resolved Hide resolved
pages/blog/websocket-part3.md Outdated Show resolved Hide resolved
pages/blog/websocket-part3.md Outdated Show resolved Hide resolved
pages/blog/websocket-part3.md Outdated Show resolved Hide resolved
pages/blog/websocket-part3.md Outdated Show resolved Hide resolved
pages/blog/websocket-part3.md Outdated Show resolved Hide resolved
pages/blog/websocket-part3.md Outdated Show resolved Hide resolved
pages/blog/websocket-part3.md Outdated Show resolved Hide resolved
pages/blog/websocket-part3.md Outdated Show resolved Hide resolved
@fmvilas
Copy link
Member

fmvilas commented May 17, 2021

🚢 🇮🇹

@derberg derberg merged commit 7831ea3 into asyncapi:master May 19, 2021
@derberg derberg deleted the websocket3 branch May 19, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numbered list needs some css love to adjust indents
3 participants