feat: add the ability to show a release candidate as pre-release in the UI #278
Conversation
|
✔️ Deploy Preview for asyncapi-website ready! 🔨 Explore the source changes: eaea13b 🔍 Inspect the deploy log: https://app.netlify.com/sites/asyncapi-website/deploys/60cafe0d8922950008edc8d1 😎 Browse the preview: https://deploy-preview-278--asyncapi-website.netlify.app |
aayushmau5
changed the title
aayushmau5
changed the title
scripts/build-post-list.js
Outdated
| if(fileName.includes('release')) { | ||
| details.isPrerelease = true | ||
| details.releaseDate = getReleaseDate(fileName) | ||
| fileName = fileName.split('-')[0] | ||
| } |
There was a problem hiding this comment.
Some assumptions have been made here by me.
- The rc will always have
releasein the filename. - The format for the filename will always be
<release-version>-<year>-<month>-<release>.md. ex.v2.1.0-2021-06-release.md.
This is being used in marking a rc aspre-releaseas well as getting the release date.
There was a problem hiding this comment.
good assumptions, and valid ones, you can put them as a comment for future generations and even refer asyncapi/spec#513 (comment) in the comment for future generations
|
🤔 Do we add the |
|
@aayushmau5 I'm honestly not sure, there are pros and cons for both. So maybe just leave it as it is, |
|
@derberg Made some changes. Please review :) |
|
Yeah, I think so. Everything done on the website side. Made some changes on the Actions. Just need to verify it, and then, we can merge it. |
Description
Screeshots
Related issue(s)
#86