Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve display of clear filters button #817

Closed
wants to merge 1 commit into from
Closed

feat: improve display of clear filters button #817

wants to merge 1 commit into from

Conversation

Olaleye-Blessing
Copy link
Contributor

only show the button when there is/are filter(s)

Related issue(s)

Resolves: #816

@netlify
Copy link

netlify bot commented Jun 10, 2022 •
edited
Loading

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5aa202e
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/62a33444cfa9d00009d3c08b
😎 Deploy Preview https://deploy-preview-817--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jun 10, 2022 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 53
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-817--asyncapi-website.netlify.app/

@Olaleye-Blessing
Copy link
Contributor Author

@reviewers, I don't know why I've so many changes in package-lock.json.
I switched to node v12.16.0 and my npm is v6.13.4. The project requires node v12.16+, npm v6.13.7+.

Should I be worried about these changes?

@magicmatatjahu
Copy link
Member

magicmatatjahu commented Jun 10, 2022 •
edited
Loading

@Olaleye-Blessing package-lock we have in version 2, but your npm tried to install in version 1, so please amend in latest commit changes from package-lock and everything will be ok. PackageLockVersion in 2 version is when you have npm v7+ version.

Edit: with your PR everything is good, you should only amend that package-lock and I will accept :)

@Olaleye-Blessing
feat: improve display of clear filters button
5aa202e 
only show the button when there is/are filter(s)

feat: improve display of clear filters button

only show the button when there is/are filter(s)

fix: package-lock.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas Awaiting requested review from fmvilas

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clear filter button shows always
2 participants
@Olaleye-Blessing @magicmatatjahu